Closed Bug 1682998 Opened 4 years ago Closed 4 years ago

sw-wr: [Fission] Crash in [@ UniformMatrix4fv]

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
86 Branch
Fission Milestone M7
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- disabled
firefox86 --- disabled

People

(Reporter: aryx, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Fission crashes from 2+ devices, oldest reported build ID is 20201213093323.

Crash report: https://crash-stats.mozilla.org/report/index/988cac6a-e1b6-4c3f-a083-d1efe0201216

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll UniformMatrix4fv gfx/wr/swgl/src/gl.cc:2190
1 xul.dll webrender::shade::LazilyCompiledShader::bind gfx/wr/webrender/src/shade.rs:144
2 xul.dll webrender::renderer::Renderer::draw_alpha_batch_container gfx/wr/webrender/src/renderer.rs:4472
3 xul.dll webrender::renderer::Renderer::draw_frame gfx/wr/webrender/src/renderer.rs:6056
4 xul.dll webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:3490
5 xul.dll webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer.rs:3246
6 xul.dll webrender_bindings::bindings::wr_renderer_render gfx/webrender_bindings/src/bindings.rs:639
7 xul.dll mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:186
8 xul.dll mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:476
9 xul.dll mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:336
Summary: [Fission] Crash in [@ UniformMatrix4fv] → sw-wr: [Fission] Crash in [@ UniformMatrix4fv]
Severity: -- → S3

This crash seems like it is occurring trying to access vertex_shader->set_uniform_matrix4fv. The crash address of 0x10 hints that vertex_shader is NULL, which would occur if for some reason we didn't set the shader. This would most likely occur because linking it failed - a bad shader name was supplied or something of that sort.

Fission Milestone: --- → M7
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc4578cb4d91 check that shaders are not null before use. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
No longer blocks: sw-wr-correctness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: