Closed Bug 1683003 Opened 4 years ago Closed 4 years ago

Update comedy-rs to remove failure dependency

Categories

(Firefox :: General, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: agashlin, Assigned: agashlin)

References

Details

Attachments

(1 file)

As noted in this PR, the comedy crate doesn't need to use failure. This bug tracks vendoring an updated comedy, and the two external crates (filetime_win and guid_win) that depend on it, as well as updating the bitsdownload component to match.

Assignee: nobody → agashlin

comedy 0.2.0 no longer impls Fail itself. By reenabling the default features
(including std) of failure, the blanket impl will cover that. These features
were disabled to remove a dependency on backtrace, but since bug 1608157 we
are using a version of failure without backtrace by default so that is no
longer needed.

Pushed by agashlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d649e34fc572 Update comedy-rs to remove dependency on failure. r=bytesized
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: