Closed Bug 1683194 Opened 4 years ago Closed 4 years ago

Screenshots taller than the window do not display when scrolled

Categories

(Firefox :: Screenshots, defect, P2)

defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- verified

People

(Reporter: cpeterson, Assigned: emmamalysz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image tall-screenshot.png (deleted) —

@ Emma, this is a regression in 86 Nightly from your fix for bug 1664444:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9c2b18e58353b67dcb3020155acd49a3f99ecaa7&tochange=90fd0f5a6bb226190fcc9312d68b3876f8c51c55

Bug 1664444 was about Fission screenshots, but this regression affects both Fission and non-Fission users.

Steps to reproduce

  1. Open a long web page.
  2. Take a screenshot of just part of the page, but drag the screenshot area down the page so the screenshot area is taller than the window height.
  3. Paste the screenshot image into another program, such as Microsoft Paint.

Expected result

The screenshot should show the complete area selected.

Actual result

The portion of the screenshot scrolled out of the window view is black. See the attached screenshot.

This bug only happens if you COPY the screenshot and PASTE into another program. If you "download" the screenshot directly from Firefox's Screenshot UI, the saved image file is complete without any black areas.

Flags: needinfo?(emalysz)
Severity: -- → S2
Priority: -- → P2
Assignee: nobody → emalysz
Flags: needinfo?(emalysz)

We will create the image using the selected position, and the canvas
will use the image coordinates, which have not been adjusted
for scrolling

Summary: Screenshots taller than the window have black areas when copy/pasted into another program → Screenshots taller than the window do not display when scrolled
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5cef92cf6ce
ignore scroll coordinates when taking screenshots r=sfoster
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: qe-verify+

Reproduced with Fx 86.0a1 (2020-12-17) on Windows 10.
Verified fixed with Fx 87.0a1 (2021-02-01) and Fx 86.0b4 on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: