Barrier state should return a property bag, not an array of property bags
Categories
(Toolkit :: Async Tooling, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Copying my comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1617559#c9:
nsIAsyncShutdownBarrier state is supposed to be a property bag:
https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/toolkit/components/asyncshutdown/nsIAsyncShutdown.idl#149
But here it's instead returning an array:
https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/toolkit/components/asyncshutdown/nsAsyncShutdown.jsm#203
The array is built here:
https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/toolkit/components/asyncshutdown/AsyncShutdown.jsm#836-848
These structures are too complex anyway, I wonder why Async Shutdown went with property bags than just stringified JSON (I imagine to help cpp consumers), my plan for now would be to convert the array of property bags into a single property bag containing json strings. That should report more useful metadata.
|
Assignee | |
Updated•4 years ago
|
| Comment hidden (off-topic) |
|
||
Comment 2•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•