Closed Bug 1683545 Opened 4 years ago Closed 4 years ago

Add later rust and gcc support to SeaMonkey

Categories

(SeaMonkey :: General, task)

SeaMonkey 2.53 Branch
task
Not set
normal

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.6)

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1682424 +++

2.53.6 needs a few backports to support rust 1.48 and gcc 11. These are partially also needed for 2.57 so moving them into a separate bug.

Attached patch 1683545-fixgcc11-2536.patch (deleted) — Splinter Review

Trivial bugfix for gcc 11 support

Attachment #9194137 - Flags: review+
Attachment #9194137 - Flags: approval-comm-release+
Attachment #9194137 - Flags: approval-comm-esr60+
Attached patch TOP-1683545-rust148-2536.patch (deleted) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Building with rust 1.48 fails. Needs rust 1.38 or higher because of Cargo.lock changes
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): build fix
String changes made by this patch: --

Attachment #9194138 - Flags: review?(iann_bugzilla)
Attachment #9194138 - Flags: approval-comm-release?
Attachment #9194138 - Flags: approval-comm-esr60?

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Building with rust > 1.37 will fail.
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): build fix not needed for 2.57
String changes made by this patch: --

Attachment #9194139 - Flags: review?(iann_bugzilla)
Attachment #9194139 - Flags: approval-comm-release?

Not really a compiler fix but well...

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: error output in about:support and console
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Attachment #9194140 - Flags: review?(iann_bugzilla)
Attachment #9194140 - Flags: approval-comm-release?
Attachment #9194140 - Flags: approval-comm-esr60?

Comment on attachment 9194138 [details] [diff] [review]
TOP-1683545-rust148-2536.patch

[Triage Comment]
Thanks r/a=me

Attachment #9194138 - Flags: review?(iann_bugzilla)
Attachment #9194138 - Flags: review+
Attachment #9194138 - Flags: approval-comm-release?
Attachment #9194138 - Flags: approval-comm-release+
Attachment #9194138 - Flags: approval-comm-esr60?
Attachment #9194138 - Flags: approval-comm-esr60+

Comment on attachment 9194139 [details] [diff] [review]
TOP-1683545-PLASTER-fixrustcompile-2536.patch

[Triage Comment]
LGTM r/a=me

Attachment #9194139 - Flags: review?(iann_bugzilla)
Attachment #9194139 - Flags: review+
Attachment #9194139 - Flags: approval-comm-release?
Attachment #9194139 - Flags: approval-comm-release+

Comment on attachment 9194140 [details] [diff] [review]
TOP-1683545-PLASTER-webrender-2536.patch

[Triage Comment]
r/a=me

Attachment #9194140 - Flags: review?(iann_bugzilla)
Attachment #9194140 - Flags: review+
Attachment #9194140 - Flags: approval-comm-release?
Attachment #9194140 - Flags: approval-comm-release+
Attachment #9194140 - Flags: approval-comm-esr60?
Attachment #9194140 - Flags: approval-comm-esr60+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: