Ensure the restoring tab is not reused in addMultipleTabs
Categories
(Firefox :: Session Restore, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: tt, Assigned: tt)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
See https://bugzilla.mozilla.org/show_bug.cgi?id=1665942#c26.
It's possible that the selected tab is going to be reused but its tab state hasn't been reseted in SessionStore while restoring windows.
The issue was hidden in some cases because the userContextId attribute was undefined which causes bypassing the if-check.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Backed out with Bug 1665942 for failures on browser_cookies_legacy.js
backout: https://hg.mozilla.org/integration/autoland/rev/2149651d7eb759e867b44d115298480399be1f1b
failure log: https://treeherder.mozilla.org/logviewer?job_id=330222914&repo=autoland&lineNumber=24423
[task 2021-02-17T11:02:24.051Z] 11:02:24 INFO - TEST-PASS | browser/components/sessionstore/test/browser_cookies_legacy.js | cookie added by the cookie service -
[task 2021-02-17T11:02:24.051Z] 11:02:24 INFO - Buffered messages logged at 11:00:55
[task 2021-02-17T11:02:24.058Z] 11:02:24 INFO - Leaving test bound test_window
[task 2021-02-17T11:02:24.058Z] 11:02:24 INFO - Entering test bound test_browser
[task 2021-02-17T11:02:24.059Z] 11:02:24 INFO - waiting for cookie name58626=value58626 from http://example.com...
[task 2021-02-17T11:02:24.059Z] 11:02:24 INFO - TEST-PASS | browser/components/sessionstore/test/browser_cookies_legacy.js | cookie added by the cookie service -
[task 2021-02-17T11:02:24.060Z] 11:02:24 INFO - running
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - Buffered messages finished
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_cookies_legacy.js | Test timed out -
[task 2021-02-17T11:02:24.061Z] 11:02:24 INFO - GECKO(8918) | MEMORY STAT | vsize 3410MB | residentFast 416MB | heapAllocated 105MB
[task 2021-02-17T11:02:24.063Z] 11:02:24 INFO - TEST-OK | browser/components/sessionstore/test/browser_cookies_legacy.js | took 90044ms
Comment 6•4 years ago
|
||
bugherder |
Description
•