Closed Bug 1683797 Opened 4 years ago Closed 4 years ago

rusttest jobs on automation are not actually using sccache

Categories

(Firefox Build System :: General, defect, P2)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: glandium, Assigned: mhentges)

Details

Attachments

(4 files, 2 obsolete files)

Bug 1683797: Removes unnecessary lines from client.mk
(deleted), text/x-phabricator-request
Details
Bug 1683797: Removes redundant path parsing
(deleted), text/x-phabricator-request
Details
Bug 1683797: Don't use "build targets" to build rusttests
(deleted), text/x-phabricator-request
Details
Bug 1683797: Remove obsolete "build_targets" option from CI
(deleted), text/x-phabricator-request
Details

They don't return sccache stats or the sccache log like other builds (which in itself is something that should be fixed), so this is not directly visible, but it turns out they are trying (and I guess failing) to use/store the cache in GCS for builds on AWS.

It turns out we always set a GCS-related variable, so the previous statement was misled. The result of the current config is that sccache is not actually used (actually, it probably uses a local cache that always starts empty, which means the builds are also slower than they would be without sccache at all).

Summary: rusttest jobs on automation are using sccache wrongly → rusttest jobs on automation are not actually using sccache
Assignee: nobody → mhentges
Priority: -- → P2
Status: NEW → ASSIGNED

CWD is never used, and an ifdef MACH can be removed if the
"$MACH is set" assertion is prioritized.

  • Always use client.mk in mach when targets are used
  • Pass targets forward into "real" mach invocation in client.mk

Depends on D102661

Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3654ee48ff4 Removes unnecessary lines from client.mk r=sheehan,firefox-build-system-reviewers,glandium

Thanks! Learning some make goodies here, will resolve this next week after a chat with Glandium

Flags: needinfo?(mhentges)
Attached file Bug 1683797: Removes redundant path parsing (obsolete) (deleted) —

We already know the project name, we should unbundle it
from the project path.

Depends on D102661

Attachment #9198539 - Attachment is obsolete: true

We already know the project name, we should unbundle it
from the project path.

Depends on D102661

  • Move and denormalizes rusttests mozconfigs
  • Modify baseconfig.mk to change tiers if running rusttests
  • Adjust CI config to use new "rusttests" build "application"

Depends on D106293

Rusttests were the only remaining usage.

Depends on D106294

Attachment #9201812 - Attachment is obsolete: true
Attachment #9205152 - Attachment description: Bug 1683797: Move rusttests to separate build "application" → Bug 1683797: Don't use "build targets" to build rusttests
Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/3457334cbaf9 Removes unnecessary lines from client.mk r=sheehan,firefox-build-system-reviewers,glandium https://hg.mozilla.org/mozilla-central/rev/697524537cc4 Removes redundant path parsing r=sheehan,firefox-build-system-reviewers,glandium https://hg.mozilla.org/mozilla-central/rev/a97de4385cf6 Don't use "build targets" to build rusttests r=sheehan,firefox-build-system-reviewers,glandium https://hg.mozilla.org/mozilla-central/rev/00d3fcc38474 Remove obsolete "build_targets" option from CI r=sheehan,releng-reviewers,jmaher
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: