Replace MOZ_MUST_USE with [[nodiscard]] in js/src/jit/
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Tracking
()
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(2 files)
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
The [[nodiscard]] attribute must precede a function declaration's declaration specifiers (like static, extern, inline, or virtual). The __attribute__((warn_unused_result)) attribute does not have this order restriction.
|
Assignee | |
Comment 1•4 years ago
|
||
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
The [[nodiscard]] attribute must precede a function declaration's declaration specifiers (like static, extern, inline, or virtual). The attribute((warn_unused_result)) attribute does not have this order restriction.
Depends on D100408
|
|
Assignee | |
Comment 3•4 years ago
|
||
Green Try build:
https://treeherder.mozilla.org/jobs?repo=try&revision=35b66f8043dbf36d4b5175f44497686f84043377
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5a8ad0b7d2d Part 1: Replace MOZ_MUST_USE with [[nodiscard]] in js/src/jit/. r=jandem https://hg.mozilla.org/integration/autoland/rev/96c385db5906 Part 2: Move [[nodiscard]] to the head of function declarations in js/src/jit/. r=jandem
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c5a8ad0b7d2d
https://hg.mozilla.org/mozilla-central/rev/96c385db5906
Description
•