Fix build with Rust nightly
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr7886+ fixed, firefox85- wontfix, firefox86 fixed)
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
dependency (nix) specification is ambiguous. Only one of
branch,tagorrevis allowed.
|
Assignee | |
Comment 1•4 years ago
|
||
Fixes errors like:
dependency (nix) specification is ambiguous. Only one of branch, tag or rev is allowed.
I've left the most specific dependency, but for wgpu the rev is not
right, so I've kept the branch which effectively preserves behavior.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
Fwiw, maybe this should be backported to release or at least to esr78. Those fail to build with the just-released rust 1.50.
|
|
Assignee | |
Comment 5•4 years ago
|
||
Comment on attachment 9194752 [details]
Bug 1684261 - Fix build with rust nightly. r=jrmuizel,#build
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix
- User impact if declined: None
- Fix Landed on Version: 86
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky, build only change.
- String or UUID changes made by this patch: none
|
|
||
Comment 6•4 years ago
|
||
thunderbird 78.7.1 also fails with rust 1.50.
|
||
Comment 7•4 years ago
|
||
No need to track tb separately AIUI, there's no tb-specific change.
|
||
Updated•4 years ago
|
|
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9194752 [details]
Bug 1684261 - Fix build with rust nightly. r=jrmuizel,#build
Approved for 78.8esr.
|
|
||
Comment 9•4 years ago
|
||
| bugherder uplift | ||
Description
•