Closed Bug 1684500 Opened 4 years ago Closed 4 years ago

Improve the ICS file import dialog

Categories

(Calendar :: Import and Export, enhancement)

enhancement

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(5 files)

There's many things that could be better about the ICS file import. I've filed bugs on several of them already, but I'm going to use this new bug to cover several more:

  • The list of calendars to import into shows calendars that are disabled.
  • "All day" items show the wrong end date (although technically the end date is the day after the last day of an all-day event, that's not how it should be displayed).
  • There's no indication of anything happening while the import is in process.
  • Performance for large ICS files is pretty bad.

Also adds the dot representing the calendar's colour to the UI. This matches the event editing dialog.

Depends on D100541

I've broken the UI into three panes for easier handling: the existing item selection UI, progress, and results.

Depends on D100543

With this patch we'll show a "loading…" message until everything is ready.

We'll also delay actual loading until the dialog has been displayed, so the user doesn't have to wait (what can be several seconds) for something to happen.

Finally we'll improve the performance of the item summary custom element by parsing its contents only once.

Depends on D100544

The menu list is never used – it's based on a preference that doesn't exist anywhere else in the code.

The existence of the list and its descendants considerably slows down the layout of the summary custom element.
That's not a problem when there's only one element, but in the ICS file import dialog there could be hundreds.

Depends on D100545

(In reply to Geoff Lankow (:darktrojan) from comment #3)

Created attachment 9194914 [details]
Bug 1684500 - Show import progress in the ICS file import dialog

I've broken the UI into three panes for easier handling: the existing item selection UI, progress, and results.

Depends on D100543

This patch contains changes in calendar-unifinder.js which should fix parts of bug 632174.

Attachment #9194916 - Attachment description: Bug 1684500 - Remove the reminder menu list from the calendar item summary element → Bug 1684500 - Add the reminder menu list dynamically to the calendar item summary element
Attachment #9194914 - Flags: ui-review?(richard.marti)

Comment on attachment 9194914 [details]
Bug 1684500 - Show import progress in the ICS file import dialog

Yeah, it's better with progress feedback.

I need to look in new bug to make this dialog themeable.

Attachment #9194914 - Flags: ui-review?(richard.marti) → ui-review+
Attachment #9194912 - Attachment description: Bug 1684500 - Don't offer to import events into a disabled calendar → Bug 1684500 - Don't offer to import events into a disabled or read-only calendar
Depends on: 1686382
Keywords: leave-open
Target Milestone: --- → 86 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/da8693dcfc9b Don't offer to import events into a disabled or read-only calendar r=lasana https://hg.mozilla.org/comm-central/rev/3777675b862c Show the right end date for "all day" events when importing r=lasana https://hg.mozilla.org/comm-central/rev/7da2ecdc81c9 Show import progress in the ICS file import dialog r=lasana https://hg.mozilla.org/comm-central/rev/9163772f0342 Improve the performance of the ICS file import dialog for large files r=lasana
Keywords: leave-open

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/47627b7a5b34
Add the reminder menu list dynamically to the calendar item summary element r=lasana

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Duplicate of this bug: 817251
Duplicate of this bug: 1732449
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: