Closed Bug 1684756 Opened 4 years ago Closed 4 years ago

Open message from command-line using -mail <URL> parameter throws TypeError (getter-only)

Categories

(Thunderbird :: OS Integration, defect)

defect

Tracking

(thunderbird_esr78+ fixed, thunderbird86 affected)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird86 --- affected

People

(Reporter: eilaeufer, Assigned: mkmelin)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

Steps to reproduce:

  1. Open TB and select a message
  2. Open TB error console to get the message URL by entering var hdr = gFolderDisplay.selectedMessage; alert(hdr.folder.getUriForMsg(hdr));
  3. Open cmd.exe and run "thunderbird.exe -mail "<URL>"

Actual results:

Thunderbird doesn't open the message specified by the command-line parameter. Instead, the following error message in shown in the error console:

TypeError: setting getter-only property "_messenger": MailNewsCommandLineHandler.jsm:19:62 (get _messenger resource:///modules/MailNewsCommandLineHandler.jsm:19, handle resource:///modules/MailNewsCommandLineHandler.jsm:69)

Expected results:

TB should open the message specified by the comman-line parameter.

As a workaround, one can adjust the MailNewsCommandLineHandler.jsm by inserting the follwing code after line 22:

set _messenger(value) {
return value;
},

Attached patch bug1684756__messenger.patch (deleted) — Splinter Review

Learn something new every day...

Assignee: nobody → mkmelin+mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9199599 - Flags: review?(lasana)
Comment on attachment 9199599 [details] [diff] [review] bug1684756__messenger.patch Review of attachment 9199599 [details] [diff] [review]: ----------------------------------------------------------------- Ok with me.
Attachment #9199599 - Flags: review?(lasana) → review+
Target Milestone: --- → 87 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3d401dc2c803
Open message from command-line using -mail <URL> parameter throws TypeError (getter-only). r=lasana

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9199599 [details] [diff] [review]
bug1684756__messenger.patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: can't open specific url from command line
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Attachment #9199599 - Flags: approval-comm-esr78?

Comment on attachment 9199599 [details] [diff] [review]
bug1684756__messenger.patch

[Triage Comment]
Approved for esr78

Attachment #9199599 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: