Allow PathUtils.getProfileDir() to be called off main thread if PathUtils is not instantiated
Categories
(Toolkit Graveyard :: OS.File, defect)
Tracking
(firefox86 fixed)
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: barret)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
During shutdown, we are unable to use await PathUtils.getProfileDir()
due to the error here: https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/xpcom/base/ClearOnShutdown.h#125.
Should we remove that assertion?
Comment 1•4 years ago
|
||
(In reply to Emma Malysz from comment #0)
During shutdown, we are unable to use
await PathUtils.getProfileDir()
due to the error here: https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/xpcom/base/ClearOnShutdown.h#125.Should we remove that assertion?
I somewhat suspect that https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/dom/system/PathUtils.cpp#310 should be wrapped in a dispatch-to-mainthread, but I could be wrong. Barret?
Assignee | ||
Comment 2•4 years ago
|
||
PathUtils gets cleared at the ShutdownFinal stage, at which point we no longer have XPCOM, so it is unlikely this is happening at shutdown. It is more likely that this is instead running off main thread before PathUtils is instantiated.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Comment 5•4 years ago
|
||
Backed out for causing failure at send_alert_text.py.
Backout link: https://hg.mozilla.org/integration/autoland/rev/6064abc44165c8213f2be262f0c650e9be75ef82
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PGOQ6LnYQtW1MNgwOpkTSQ.0&searchStr=wd3&revision=3587cb6cc38383306d2c3d89654596f705533660
Failure log: https://treeherder.mozilla.org/logviewer?job_id=326484765&repo=autoland&lineNumber=1549
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•