Closed
Bug 1685105
Opened 4 years ago
Closed 4 years ago
XHR Breakpoint should work in remote frames
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Fission Milestone:M7, firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: Honza, Assigned: ochameau)
References
(Blocks 3 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
XHR breaktpoint should work even when XHR is executed from within remote frame.
STR:
- Load http://janodvarko.cz/tests/fission/case1/index.html
- Open DevTools and select the Debugger panel
- Check "Pause on any URL"
- Click the POST button in the remote frame
- The debugger should pause JS execution
Note that XHR BP works when HTTP is executed from top level document.
Honza
|
||
Comment 1•4 years ago
|
||
Tracking dt-fission-m3-mvp bugs for Fission M8 (blocking Release channel experiment, but not Beta experiment).
Fission Milestone: --- → M8
|
Assignee | |
Comment 2•4 years ago
|
||
It is very likely related to the same issue described in bug 1602488 comment 1.
I see two ways to fix that:
- Have Debugger frontend to loop over all Target's threadFront and call
setXHRBreakpointon all thread fronts, including the one for the remote frames. - Pass XHR breakpoints via the watcher actor, like what we did for regular breakpoints in bug 1573327.
The second option is better as it would also ensure breaking on XHR during early page load.
|
|
||
Comment 3•4 years ago
|
||
Moving dt-fission-m3-mvp bugs from Fission M8 to M7 (blocking Beta experiment).
Fission Milestone: M8 → M7
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5199ec2d73fa
[devtools] Pass XHR breakpoint via the Watcher Actor. r=nchevobbe,bomsy,devtools-backward-compat-reviewers
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•