Closed Bug 1685352 Opened 4 years ago Closed 4 years ago

Verify "Print" modal is consistent with new proton UI

Categories

(Toolkit :: Printing, task, P2)

Product:
Toolkit
Component:
Printing
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: mtigley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals] [priority:2a] [proton-uplift])

Attachments

(2 files)

Current "Print" modal UI
(deleted), image/png
Details
Bug 1685352, adjust print modal to match proton styles
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details

We should check that the "Print" modal is consistent with new designs for proton.

Whiteboard: [proton-modals]
Attached image Current "Print" modal UI (deleted) —

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Printing
Product: Firefox → Toolkit
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals][priority:2a]
Whiteboard: [proton-modals][priority:2a] → [proton-modals] [priority:2a]
Priority: P2 → P1
Priority: P1 → P2
Assignee: nobody → emalysz
Status: NEW → ASSIGNED

Some things I found were:

  1. This item: https://searchfox.org/mozilla-central/rev/08013752b4638f01d41d2a38ca7bd741bc572c86/toolkit/components/printing/content/print.css#267 needs a specified border radius to avoid looking cut off. It should be border-radius: 0 4px 4px 0; (confirmed with Emanuela)
  2. The separators in the dialog should match other menu separators (confirmed with Emanuela)
  3. Error text color is incorrect
  4. When the toggle button is disabled, it loses its button color
  5. Padding for input boxes should be 8px
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a2b343c670f adjust print modal to match proton styles r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/4a2b343c670f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9217547 [details]
Bug 1685352, adjust print modal to match proton styles

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No string changes
  • String changes made/needed: n/a
Attachment #9217547 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-modals] [priority:2a] → [proton-modals] [priority:2a] [proton-uplift]

Comment on attachment 9217547 [details]
Bug 1685352, adjust print modal to match proton styles

Approved for 89 beta 5, thanks.

Attachment #9217547 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified as fixed in our latest Nightly build as well as Beta 89.0b5.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
status-firefox90: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: