Fix serialization of complex :not to have commas in selector lists
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox84 | --- | wontfix |
firefox85 | --- | fixed |
firefox86 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
Itiel spotted this, but the bug is:
button:not([disabled], [selected]) {
color: blue;
}
displays as:
button:not([disabled][selected]) {
color: blue;
}
in the inspector.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9195976 [details]
Bug 1685621 - Fix serialization of complex :not(). r=#style
Beta/Release Uplift Approval Request
-
User impact if declined:
- Broken/misleading output in DevTools rules view when inspecting certain :not() selectors
- Broken output when returning CSS selectors via JS (not sure how frequent that is though)
-
Is this code covered by automated tests?: Yes
-
Has the fix been verified in Nightly?: No
-
Needs manual test from QE?: No
-
If yes, steps to reproduce:
-
List of other uplifts needed: None
-
Risk to taking this patch: Low
-
Why is the change risky/not risky? (and alternatives if risky): Makes
:not()
use the same codepath as:is()
and:where()
which shipped in Firefox 77. This has tests as well. -
String changes made/needed: no
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Backed out for perma failures.
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&revision=899944ef4aa72a26a3de63d48f952213ec73b2b8&selectedTaskRun=TJNsSImrT6ykbIKqqurEvA.0
Log: https://treeherder.mozilla.org/logviewer?job_id=326154715&repo=autoland&lineNumber=6269
Backout: https://hg.mozilla.org/integration/autoland/rev/2405ffdc136db3563bc49962aeb4f709c7a8e083
Updated•4 years ago
|
Updated•4 years ago
|
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7e9efe4d1265
https://hg.mozilla.org/mozilla-central/rev/84e497a940ab
Comment 10•4 years ago
|
||
Comment on attachment 9195976 [details]
Bug 1685621 - Fix serialization of complex :not(). r=#style
approved for 85.0b8
Updated•4 years ago
|
Comment 11•4 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Description
•