Closed Bug 1685621 Opened 4 years ago Closed 4 years ago

Fix serialization of complex :not to have commas in selector lists

Categories

(Core :: CSS Parsing and Computation, defect)

Firefox 84
defect

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- wontfix
firefox85 --- fixed
firefox86 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Itiel spotted this, but the bug is:

button:not([disabled], [selected]) {
  color: blue;
}

displays as:

button:not([disabled][selected]) {
  color: blue;
}

in the inspector.

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9195976 - Attachment description: Bug 1685621 - Fix serialization of complex :not to have commas in selector lists. r=#style → Bug 1685621 - Fix serialization of complex :not(). r=#style
Has Regression Range: --- → yes
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e577d67c6c42 Fix serialization of complex :not(). r=emilio

Comment on attachment 9195976 [details]
Bug 1685621 - Fix serialization of complex :not(). r=#style

Beta/Release Uplift Approval Request

  • User impact if declined:

    • Broken/misleading output in DevTools rules view when inspecting certain :not() selectors
    • Broken output when returning CSS selectors via JS (not sure how frequent that is though)
  • Is this code covered by automated tests?: Yes

  • Has the fix been verified in Nightly?: No

  • Needs manual test from QE?: No

  • If yes, steps to reproduce:

  • List of other uplifts needed: None

  • Risk to taking this patch: Low

  • Why is the change risky/not risky? (and alternatives if risky): Makes :not() use the same codepath as :is() and :where() which shipped in Firefox 77. This has tests as well.

  • String changes made/needed: no

Attachment #9195976 - Flags: approval-mozilla-beta?
Attachment #9195986 - Flags: approval-mozilla-beta?
Severity: -- → S3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e9efe4d1265 Fix serialization of complex :not(). r=emilio https://hg.mozilla.org/integration/autoland/rev/84e497a940ab Add more :not() serialization tests. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27096 for changes under testing/web-platform/tests
Flags: needinfo?(ntim.bugs)
Version: unspecified → Firefox 84
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9195976 [details]
Bug 1685621 - Fix serialization of complex :not(). r=#style

approved for 85.0b8

Attachment #9195976 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9195986 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: