Closed Bug 1685662 Opened 4 years ago Closed 4 years ago

[MIPS] Some BigInt related tests failed on mips platform

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- fixed

People

(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

No description provided.

On mips64 platform, some BitInt related jit-tests failed, like:

  • bigint/bigint-add.js
  • bigint/bigint-dec.js
  • bigint/bigint-inc.js
  • bigint/bigint-mul.js
  • etc

And it's because some functions are not implemented on mips platform, which is introduced in bug 1679750. I will try to port the changes to mips64 platform.

Blocks: 1639895
Regressed by: 1679750
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1679750

Severity: -- → S4
Priority: -- → P5

Port D98163, D98165, D98167 to mips platform.

Assignee: nobody → zhaojiazhong-hf

Add convertDoubleToPtr, move32SignExtendToPtr, spectreBoundsCheckPtr and spectreMaskIndexPtr to the MacroAssembler;

Implement MacroAssembler::branch{Add,Sub,Mul}Ptr;

Attachment #9198076 - Attachment is obsolete: true
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

It seems that this patch introduced an assert error due to misusing the scratch register. Currently, the scratch register usage on mips port is a mess, I will firstly fix this assert failure to make sure at least the tests pass.

The rt operand may be the ScratchRegister and will cause an assert fail,
now change the implementation of the function to remove the assert.

Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/b9af325a1c3d [MIPS64] Fix register conflict in ma_addPtrTestOverflow. r=lth
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: