Freeze the current defines in these two files.

I think the definitions in these files can be frozen, but the entire files can't be frozen. That is, any key that's there must remain and be supported but we will always need to add new definitions. Especially for nsDirectoryServiceDefs.h which defines many OS-defined locations. New versions of an OS come out, new locations are defined, and we need to be able to add definitions to nsDirectoryServiceDefs.h to reflect that.

sure. that makes sense for files containing pure constants

nsAppDirectoryServiceDefs.h needs to move out of xpcom. where to??

Comment on attachment 99434 [details] [diff] [review] patch v.1 we need to clean up some stuff!

not close, but closer. Not freezing application cruft that needs to be moved out of xpcom. removing private define from the Defs header.

Comment on attachment 102018 [details] [diff] [review] comment marking included defines frozen sr=alecf

Comment on attachment 102018 [details] [diff] [review] comment marking included defines frozen r=ccarlen

Comment on attachment 102018 [details] [diff] [review] comment marking included defines frozen >Index: nsDirectoryServiceDefs.h >+/* >+ * Defines the property names for directories available from nsIDirectoryService. These >+ * dirs are always available even if no nsIDirectoryServiceProviders have been registered >+ * with the service. Application level keys are defined in nsAppDirectoryServiceDefs.h. >+ * >+ * Keys whose definition ends in "DIR" or "FILE" return a single nsIFile (or subclass). >+ * Keys whose definition ends in "LIST" return an nsISimpleEnumerator which enumerates a >+ * list of file objects. >+ * >+ * Defines listed in this file are FROZEN. >+ */ comment blocks should start with /** no? are we allowed to grow this list in the future? i can't think of any reason why not, but we should perhaps mention that fact in the documentation for this header. r/sr=darin

/cvsroot/mozilla/xpcom/io/nsDirectoryServiceDefs.h,v <-- nsDirectoryServiceDefs.h new revision: 1.20; previous revision: 1.19 done