Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox86 fixed)
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
In order to ease the landing of bug 1681698, I'm going to try landing this preliminary cleanup first.
Today, ThreadActor.attach and ThreadActor.reconfigure both receive the options dictionnary, made of many attribute to configure the thread actor. But these two methods accept different sets of attributes.
The goal here would be to ensure that all options currently passed to attach would also work if passed via reconfigure. So that bug 1681698 can do that for all the options that aren't being passed via the Watcher actor, and would still need to be passed on Target's attach sequence.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Bind onExceptionUnwind only once, remove unused _scripts attribute, create _debuggerSourcesSeen from constructor.
|
||
Updated•4 years ago
|
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d3a4810639c
https://hg.mozilla.org/mozilla-central/rev/f9dceeaea9d8
https://hg.mozilla.org/mozilla-central/rev/76519f62b9c0
Description
•