Closed Bug 1687177 Opened 4 years ago Closed 4 years ago

<input type="date/time"> focused state is overlapping with the input borders, with non-native theming

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Platform:
Unspecified
Windows
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox-esr78 --- disabled
firefox84 --- disabled
firefox85 --- disabled
firefox86 --- disabled
firefox87 --- verified

People

(Reporter: itiel_yn8, Assigned: emilio)

References

Details

Attachments

(3 files)

<input type="date">
(deleted), image/png
Details
<input type="time">
(deleted), image/png
Details
Bug 1687177 - <input type=date> and <input type=time> shouldn't have different padding from other inputs. r=spohl,mstange
(deleted), text/x-phabricator-request
Details
Attached image <input type="time"> (deleted) —
Blocks: remove-native-theming
No longer blocks: 1615105

I can reproduce on Windows. On my Windows laptop, the blue highlight doesn't overlap with the widget's bottom blue border, but the padding between the top and bottom borders is asymmetrical.

TBD: Does this bug also affect Linux?

Fission Milestone: --- → ?
status-firefox84: --- → disabled
status-firefox85: --- → disabled
status-firefox86: --- → disabled
status-firefox87: --- → affected
status-firefox-esr78: --- → disabled
OS: Unspecified → Windows

Emilio, can you reproduce this non-native theming bug on Linux? I can reproduce on Windows.

Flags: needinfo?(emilio)

It was in fact an odd special-case which caused trouble on some tests as
well.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54b681845663 <input type=date> and <input type=time> shouldn't have different padding from other inputs. r=spohl
Severity: -- → S3
Fission Milestone: ? → M7
Priority: -- → P3

https://hg.mozilla.org/mozilla-central/rev/54b681845663

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Flags: qe-verify+

I have reproduced this issue using Firefox 86.0a1 (2021.01.17) on Ubuntu 20.04 x64.
I can confirm this issue is fixed, I verified using Firefox 88.0a1 and 87.0b4 ( with pref widget.disable-native-theme-for-content = true) on Ubuntu 20.04 x64, Win 8.1 x64 and macOS 11.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: