Closed
Bug 1687631
Opened 4 years ago
Closed 4 years ago
Review "CPU Utilization" description and default in about:profiling, after the front-end piece becomes public
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(3 files)
When https://github.com/firefox-devtools/profiler/pull/3098 lands, we can remove the extra about:config URL from the description introduced in bug 1687603.
|
Assignee | |
Comment 1•4 years ago
|
||
Front-end work is under review, I'll prepare a patch here for when it lands.
Also, given the enthusiasm from early users, I'm thinking of making it "recommended" (i.e., default ON) and add it to all presets.
Assignee: nobody → gsquelart
Summary: Review "CPU Utilization" description in about:profiling, after the front-end piece becomes public → Review "CPU Utilization" description and default in about:profiling, after the front-end piece becomes public
|
|
Assignee | |
Comment 2•4 years ago
|
||
Also since the front-end handling is now deployed, there is no need to mention the deploy preview URL anymore.
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D107597
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D107598
|
||
Updated•4 years ago
|
Attachment #9207677 -
Attachment description: Bug 1687631 - Enable ProfilerFeature::CPUUtilization by default in the profilers - r?canaltinova,florian → Bug 1687631 - Enable CPU Utilization by default in the profilers - r?canaltinova,florian
|
|
||
Updated•4 years ago
|
Attachment #9207678 -
Attachment description: Bug 1687631 - Add cpu profiler feature to performance-new and Raptor tests - r?canaltinova,florian → Bug 1687631 - Add cpu profiler feature to stack-walking profiling tests - r?canaltinova,florian
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d13f26700da
about:profiling CPU Utilization is now recommended and in all presets - r=florian
https://hg.mozilla.org/integration/autoland/rev/f479b1885056
Enable CPU Utilization by default in the profilers - r=florian
https://hg.mozilla.org/integration/autoland/rev/d1e1065713d0
Add cpu profiler feature to stack-walking profiling tests - r=florian,perftest-reviewers,sparky
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d13f26700da
https://hg.mozilla.org/mozilla-central/rev/f479b1885056
https://hg.mozilla.org/mozilla-central/rev/d1e1065713d0
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•