Closed Bug 1687876 Opened 4 years ago Closed 4 years ago

/css/css-flexbox/radiobutton-min-size.html fails with the non-native theme enabled

Categories

(Core :: Widget, defect, P3)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: heycam, Assigned: emilio)

Details

(Whiteboard: fission-nnt, [wptsync upstream])

Attachments

(1 file, 1 obsolete file)

Needs investigation. Radio button in a flex container is unexpectedly stretched vertically.

Tracking non-native theming test failures for Fission M7 Beta.

Fission Milestone: --- → M7

This fails in literally every other platform, so I think we're good.

Severity: -- → S3
Priority: -- → P3
Whiteboard: fission-nnt

This test also fails in Safari and that's tracked by https://bugs.webkit.org/show_bug.cgi?id=210091. Firefox and Safari don't fail in exactly the same way, however, it's "expected 16 but got 14" in Firefox but "expected 0 but got 12" in Safari.

This is not nnt specific.

Furthermore I think the test might be invalid, as in, there's no guarantee for the height to be equal. I think the height of the resizer at the top is stretched due to the flexbox algorithm to the line height of the text, while the bottom one is not because it's just a block. Chromium doesn't seem to treat checkboxes like a proper replaced element, so I think that might be a chromium bug.

Other than that Firefox is meeting the test expectation (that the check that the checkbox doesn't go to zero-size, which is what Safari does).

No longer blocks: 1687866

This prevents them from eg. stretching vertically on flexbox (and more
generally makes sense).

Assignee: nobody → emilio
Status: NEW → ASSIGNED

I looked a bit more, and I think checkbox / radio should definitely report their intrinsic aspect ratio, which fixes the test as expected too.

Attachment #9201058 - Attachment is obsolete: true

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

I looked a bit more, and I think checkbox / radio should definitely report their intrinsic aspect ratio, which fixes the test as expected too.

That wouldn't match all-browser's behavior for stuff like data:text/html,<input type=radio style="height: 100px">. So I think this is just a test bug then.

Gecko treats it more like a replaced element and stretches it
vertically, which doesn't seem wrong to me. The spec for form control
rendering should be clearer about what is the right behavior, but I
don't think the test expectation is particularly correct.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a60a089a25ea Fix wrong assumption in radiobutton-min-size.html. r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27486 for changes under testing/web-platform/tests
Whiteboard: fission-nnt → fission-nnt, [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: