/css/css-flexbox/radiobutton-min-size.html fails with the non-native theme enabled
Categories
(Core :: Widget, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: heycam, Assigned: emilio)
Details
(Whiteboard: fission-nnt, [wptsync upstream])
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Needs investigation. Radio button in a flex container is unexpectedly stretched vertically.
Comment 1•4 years ago
|
||
Tracking non-native theming test failures for Fission M7 Beta.
Assignee | ||
Comment 2•4 years ago
|
||
This fails in literally every other platform, so I think we're good.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
This test also fails in Safari and that's tracked by https://bugs.webkit.org/show_bug.cgi?id=210091. Firefox and Safari don't fail in exactly the same way, however, it's "expected 16 but got 14" in Firefox but "expected 0 but got 12" in Safari.
Assignee | ||
Comment 4•4 years ago
|
||
This is not nnt specific.
Furthermore I think the test might be invalid, as in, there's no guarantee for the height to be equal. I think the height of the resizer at the top is stretched due to the flexbox algorithm to the line height of the text, while the bottom one is not because it's just a block. Chromium doesn't seem to treat checkboxes like a proper replaced element, so I think that might be a chromium bug.
Other than that Firefox is meeting the test expectation (that the check that the checkbox doesn't go to zero-size, which is what Safari does).
Assignee | ||
Comment 5•4 years ago
|
||
This prevents them from eg. stretching vertically on flexbox (and more
generally makes sense).
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
I looked a bit more, and I think checkbox / radio should definitely report their intrinsic aspect ratio, which fixes the test as expected too.
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)
I looked a bit more, and I think checkbox / radio should definitely report their intrinsic aspect ratio, which fixes the test as expected too.
That wouldn't match all-browser's behavior for stuff like data:text/html,<input type=radio style="height: 100px">
. So I think this is just a test bug then.
Assignee | ||
Comment 8•4 years ago
|
||
Gecko treats it more like a replaced element and stretches it
vertically, which doesn't seem wrong to me. The spec for form control
rendering should be clearer about what is the right behavior, but I
don't think the test expectation is particularly correct.
Comment 11•4 years ago
|
||
bugherder |
Description
•