Closed Bug 1687909 Opened 4 years ago Closed 2 years ago

Linux: automatic refresh rate detection (set layout.frame_rate automatically)

Categories

(Core :: Widget: Gtk, enhancement, P4)

Firefox 86
enhancement

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: thibaultmolleman, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

  • Switch monitor to a refreshrate above 60hz
  • Restart firefox fully

Actual results:

go to ufotest.com
see that it's still only outputting 60fps

Expected results:

I would expect firefox to automatically switch to my displays refreshrate (120hz)
Setting layout.frame_rate in about:config to 120 works. But I feel like this should just be done automatically. I only became aware about this after seeing a reddit post about it: https://www.reddit.com/r/linux/comments/l1re17/psa_by_default_firefox_on_linux_doesnt_match_with/?utm_medium=android_app&utm_source=share

Summary: Linux: automatic refresh rate detection → Linux: automatic refresh rate detection (set layout.frame_rate automatically)

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Layout
Product: Firefox → Core
Component: Layout → Graphics
Severity: -- → S4
Type: defect → enhancement
Component: Graphics → Widget: Gtk
Priority: -- → P4

I assume you're using the Wayland backend? Because on X11 we've been supporting this for years I AFAIK. On Wayland it only landed in bug 1645528 - shipping in 86 :)

P.S.: or on X11 using software rendering - Firefox only has vsync and thus frame rate detection on X11 when using hardware rendering. You can check https://wiki.mozilla.org/Platform/GFX/WebRender_Where to see where it's enabled by default - it will get more over the next couple of releases!

Flags: needinfo?(thibaultmolleman)

(In reply to Robert Mader [:rmader] from comment #2)

I assume you're using the Wayland backend? Because on X11 we've been supporting this for years I AFAIK. On Wayland it only landed in bug 1645528 - shipping in 86 :)

P.S.: or on X11 using software rendering - Firefox only has vsync and thus frame rate detection on X11 when using hardware rendering. You can check https://wiki.mozilla.org/Platform/GFX/WebRender_Where to see where it's enabled by default - it will get more over the next couple of releases!

I haven't bothered with wayland yet on that machine. Only x11.
I've been switching between prop and nouveau drivers (gtx 1080) but I guess both are still kinda wip. I might with the Firefox beta or nightly and see how that affects things

(In reply to thibaultmolleman from comment #3)

I've been switching between prop and nouveau drivers (gtx 1080) but I guess both are still kinda wip. I might with the Firefox beta or nightly and see how that affects things

Right, on nvidia hardware you'll not get Webrender on the release channel right now. You could, however, enable gfx.webrender.all in about:config and see if it works well for you.

I suppose we can close this as dup of bug 1535716 or so - the feature is there, just not enabled by default in all configurations.

Sorry for the long response time. I haven't yet tried on wayland. But so far on X11:
Both firefox 88 and firefox nightly (90) do 60 fps on the ufo test. (both when my display is on 60hz or 120hz)
When I toggle gfx.webrender.all on, then my performance just tanks and it never goes above 30 (kinda feel like it's capped at 30 now actually).

I 'Killall firefox' 'd after every setup modification

Flags: needinfo?(thibaultmolleman)

Is this issue/suggestion covered in bug 1535716? If yes, is it covered completely?
Please set it as duplicate or confirm it if the suggestion makes sense. Thank you!

Flags: needinfo?(robert.mader)

(In reply to Bodea Daniel [:danibodea] from comment #6)

Is this issue/suggestion covered in bug 1535716? If yes, is it covered completely?
Please set it as duplicate or confirm it if the suggestion makes sense. Thank you!

The suggestion makes sense, it's most likely the case. However:

When I toggle gfx.webrender.all on, then my performance just tanks and it never goes above 30

sounds strange - on a low level intel device I easily get 60fps with or without WR.

thibaultmolleman, can you share your about:support from nightly with WR enabled, so we can see more what's going on? Thanks!

Flags: needinfo?(robert.mader) → needinfo?(thibaultmolleman)

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Flags: needinfo?(thibaultmolleman)
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.