Closed
Bug 1688350
Opened 4 years ago
Closed 4 years ago
Don't export symbols from irregexp
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In this reddit post, windbg got confused and started reporting that symbols from irregexp were being inlined into XPCOM code. Ted pointed out that it was weird that they had been exported at all, which made me realize that I'd added this ifdef in RegExpShim.h. In retrospect, it's completely unnecessary.
|
Assignee | |
Comment 1•4 years ago
|
||
Drive-by: update MOZ_MUST_USE to [[nodiscard]].
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea56f894b31d
Don't export symbols from irregexp r=tcampbell
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•