Closed
Bug 1688510
Opened 4 years ago
Closed 4 years ago
ApplicationReputation.cpp: do not use 'else' after 'return'
Categories
(Toolkit :: Safe Browsing, task)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: me)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/7431701c98da9218fda314a54efa1a3093760f65/toolkit/components/reputationservice/ApplicationReputation.cpp#1332-1334
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Updated•4 years ago
|
Component: General → Safe Browsing
Product: Core → Toolkit
|
Assignee | |
Comment 1•4 years ago
|
||
Removed the 'else' statement to resolve clang-tidy warning.
|
||
Updated•4 years ago
|
Assignee: nobody → me
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/566ad2daef0b
do not 'else' after 'return' in ApplicationReputation.cpp r=sylvestre
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•