Closed
Bug 1688884
Opened 4 years ago
Closed 4 years ago
Use Span for BaseCompilationStencil.bigIntData
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
BaseCompilationStencil.bigIntData currently uses Vector, but we can use Span instead, to reduce the size.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
When compiling, source is allocated in LifoAlloc.
When decoding, source points XDR buffer.
Depends on D103159
|
|
Assignee | |
Comment 3•4 years ago
|
||
To avoid accessing BigIntStencil from constant folding, calculate isZero
and store it into BigIntLiteral.
Depends on D103160
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/38a0b23f92b6
Part 1: Do not use ParserBase::getCompilationStencil inside Parser. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/52f0950e9328
Part 2: Use LifoAlloc and XDR buffer for BigIntStencil source. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/66dd79dcf4d9
Part 3: Use Span for BaseCompilationStencil.bigIntData. r=tcampbell
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/38a0b23f92b6
https://hg.mozilla.org/mozilla-central/rev/52f0950e9328
https://hg.mozilla.org/mozilla-central/rev/66dd79dcf4d9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•