Optimized shaders produce completely broken rendering on Huawei MediaPad M2 (Mali-T628)
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: jnicol, Assigned: jnicol)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Originally raised as part of bug 1687554, however on further investigation the issue is unrelated to, and long predates, the recent regression on the HTC 10.
Rendering is completely broken. Mozregression points to the commit which introduced optimized shaders. Setting gfx.webrender.use-optimized-shaders=false
fixes rendering completely.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
By reducing the shader by hand, I managed to establish that removing the uniform sampler2D sGpuCache
declaration from the fragment shader is what breaks the rendering. Manually adding the declaration back to the optimized fragment shaders fixes it.
I have so far been unable to work out why this is the case. I plan to disable optimized shaders on Mali-T6xx in the meantime.
Assignee | ||
Comment 3•4 years ago
|
||
Webrender's pre-optimized shaders result in completely broken
rendering on a Huawei MediaPad M2 (Mali-T628). As a precaution,
disable optimized shaders on all Mali-T6xx devices.
Comment 5•4 years ago
|
||
Backed out changeset 5338c029ee7c (Bug 1689064) for causing GTest failures CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer?job_id=329560064&repo=autoland&lineNumber=28275
https://treeherder.mozilla.org/logviewer?job_id=329560493&repo=autoland&lineNumber=28469
https://treeherder.mozilla.org/logviewer?job_id=329558936&repo=autoland&lineNumber=28255
Backout: https://hg.mozilla.org/integration/autoland/rev/6970f524758af309e3724c2bef6917d95049a596
Assignee | ||
Comment 6•4 years ago
|
||
Ah, the tests crash because the new feature doesn't get initialized by them. A clever way of ensuring new features get tested properly! I'll initialize the feature and add the relevant assertions to the tests.
Comment 8•4 years ago
|
||
Backed out changeset e602ff8fea83 (bug 1689064) for assertion failures in gfxFeature.cpp.
https://hg.mozilla.org/integration/autoland/rev/160b47b7163e1a80ac366e0ef9fc10b631c35c03
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=e602ff8fea8362db48bafff91ac6a127a82b0836&selectedTaskRun=L8gQ-AnzQfyBJoOTass6lQ.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=329607723&repo=autoland&lineNumber=1580
Assignee | ||
Comment 9•4 years ago
|
||
Sorry! It looks like I need to call ConfigureFromBlocklist()
before ForceDisable()
because webrender is disabled. Not sure why it only fails on windows and not linux where I tested..
This run looks greener so far: https://treeherder.mozilla.org/jobs?repo=try&revision=911750f05096b5f92384cd8855bcdcce7dc72352
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
bugherder |
Description
•