Closed
Bug 1689285
Opened 4 years ago
Closed 4 years ago
fix test_visibility.xhtml with the non-native theme enabled.
Categories
(Core :: Widget, defect, P3)
Core
Widget
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Whiteboard: fission-nnt)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:
wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'
Get what we want to test more explicitly by setting the height of the
menuitems appropriately.
|
||
Updated•4 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b30dc27f552
Fix test_visibility.xhtml to not depend on theme values. r=eeejay
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b797209cf307
Backed out changeset 7b30dc27f552 for causing accessible failures in test_visibility.xhtml
|
||
Updated•4 years ago
|
Severity: -- → S3
Fission Milestone: --- → M7
Priority: -- → P3
Whiteboard: fission-nnt
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c73a3ef1672
Fix test_visibility.xhtml to not depend on theme values. r=eeejay
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•