Remove non-syntactic scope support from JSExecutionContext
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
(Technically this code is in dom/base, but SpiderMonkey is more interested in the change)
The last remaining use of JSExecutionContext::SetScopeChain is in the nsPAPI plugin code which is slated for removal. Once this is done, we can remove support for non-syntactic script compilation which is being deprecated in spidermonkey.
Note that ScriptPreloader/FrameScripts continue to use non-syntactic envs, but use different loader code (and will probably be changed as well).
Note that inline event handler script still uses non-syntactic envs in future, but only with CompileFunction, while it is only global-scripts that we are deprecating.
|
||
Comment 1•4 years ago
|
||
Just in case you missed it, JSExecutionContext::SetScopeChain is now unused and could be removed. Might be nice to do soonish before it finds new uses.
|
Assignee | |
Comment 2•4 years ago
|
||
The last use of this method was the NSPAPI plugin code which has now been
removed. These non-syntactic exotic environments were used for non-standard
situations and suffered numerous performance and correctness issues so are
deprecated in general.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•