Closed
Bug 1689408
Opened 4 years ago
Closed 4 years ago
Memory leak in GeckoTelemetryDelegate::DispatchHistogram
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox84 wontfix, firefox85 wontfix, firefox86 fixed, firefox87 fixed)
RESOLVED
FIXED
87 Branch
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [geckoview:m87])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
The JNI code copies the array, so we're just making and leaking a redundant copy of a nsTArray.
|
Assignee | |
Comment 1•4 years ago
|
||
mozilla::jni::LongArray::New makes a copy of the array data. We were
allocating a nsTArray on the heap and then just leaking it.
|
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S2
Keywords: regression
Priority: -- → P1
Regressed by: 1566367
Whiteboard: [geckoview:m87]
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/274046da6b42
Fix a memory leak in GeckoTelemetryDelegate::DispatchHistogram; r=geckoview-reviewers,agi
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
|
|
Assignee | |
Updated•4 years ago
|
status-firefox85:
--- → affected
status-firefox86:
--- → affected
|
|
Assignee | |
Comment 4•4 years ago
|
||
Comment on attachment 9199840 [details]
Bug 1689408: Fix a memory leak in GeckoTelemetryDelegate::DispatchHistogram; r=#geckoview-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Memory leaks
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial fix.
- String changes made/needed:
Attachment #9199840 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Updated•4 years ago
|
status-firefox84:
--- → affected
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9199840 [details]
Bug 1689408: Fix a memory leak in GeckoTelemetryDelegate::DispatchHistogram; r=#geckoview-reviewers
Approved for 86 beta, thanks.
Attachment #9199840 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Updated•4 years ago
|
|
|
||
Comment 6•4 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•