Closed
Bug 1689696
Opened 4 years ago
Closed 4 years ago
Use clearer name for WellKnownParserAtoms_ROM and StaticStrings constants
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
WellKnownParserAtoms_ROM and StaticStrings shares some definitions,
and uses different definitions in some case.
it's better using same naming convention, and unify more part if possible.
|
Assignee | |
Comment 1•4 years ago
|
||
Given it's a table for optimization purpose, the name should be explicit.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D103542
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D103543
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D103544
|
|
Assignee | |
Comment 5•4 years ago
|
||
This is necessary to use the result of StaticStrings::getLength2IndexStatic
in switch-case.
Depends on D103545
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/e37d99797ded
Part 1: Rename SmallCharArray to SmallCharTable. r=nbp
https://hg.mozilla.org/integration/autoland/rev/f492dece6fc8
Part 2: Share NUM_LENGTH2_ENTRIES constant. r=nbp
https://hg.mozilla.org/integration/autoland/rev/6277b1471a52
Part 3: Add StaticStrings::{firstCharOfLength2,secondCharOfLength2}. r=nbp
https://hg.mozilla.org/integration/autoland/rev/dd79655ccf40
Part 4: Add comment about frontend-VM map for well-known/static atom table. r=nbp
https://hg.mozilla.org/integration/autoland/rev/54f702a54f06
Part 5: Use toSmallChar in getLength2IndexStatic to make it always constexpr. r=nbp
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e37d99797ded
https://hg.mozilla.org/mozilla-central/rev/f492dece6fc8
https://hg.mozilla.org/mozilla-central/rev/6277b1471a52
https://hg.mozilla.org/mozilla-central/rev/dd79655ccf40
https://hg.mozilla.org/mozilla-central/rev/54f702a54f06
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•