Closed Bug 1689892 Opened 4 years ago Closed 4 years ago

Hide more operation behind ParserAtomsTable

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 2 open bugs)

Details

Attachments

(31 files, 1 obsolete file)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

There are a little more places that retrieves ParserAtom from ParserAtomsTable (or CompilationStencil) and operate on it.
if we want to add TaggedParserAtomIndex without entry, those operation needs to be hidden behind ParserAtomsTable.

Some operations that needs to be performed without entry instance:

  • ParserAtomEntry::isPrivateName [1]
  • StringBuffer::append [2][3]
  • ParserAtomEntry::toNumber [4]
  • ParserAtomEntry::isIndex [5][6][7]
  • ParserAtomEntry::concatAtoms [8][9]
    • this needs InflatedChar16Sequence and SpecificParserAtomLookup to be rewritten
  • QuoteString [10]
  • several dump operations in ParseNode.cpp
  • IsExtendedUnclonedSelfHostedFunctionName [11]
  • ParserAtomToNewUTF8CharsZ [12]
  • CompilationStencil::getParserAtomAt + toJSAtom [13]

toJSAtom/equalsJSAtom calls [14][15][16] will be removed by bug 1660275
ReservedWordTokenKind/IsKeyword calls [17][18][19] will be removed by bug 1687634

[1] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/BytecodeEmitter.cpp#1768
[2] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/BytecodeEmitter.cpp#9305-9309
[3] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#7440-7442
[4] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/FoldConstants.cpp#468-472
[5] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/FoldConstants.cpp#1096-1099
[6] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#8205-8206
[7] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#10828-10831
[8] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/FoldConstants.cpp#1220-1257
[9] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#2434-2445
[10] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/ParseContext.cpp#183-185
[11] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#2952-2953
[12] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/wasm/AsmJS.cpp#1040-1044
[13] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Stencil.cpp#219-221
[14] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/EmitterScope.cpp#343-346
[15] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/ParseContext.cpp#432-435
[16] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#1517-1529
[17] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#408-410
[18] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#4821-4824
[19] https://searchfox.org/mozilla-central/rev/0a489e67575540f5aeb968208ae03ff17eb71e94/js/src/frontend/Parser.cpp#10223-10232

one toJSAtom call will be kept in bug 1660275, that can be converted to equalsJSAtom, and that way we still can hide the entry instance

Blocks: 1690634
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Also made ParserAtom::isPrivateName not to return true for '#' atom.

Depends on D104015

Depends on D104016

Depends on D104017

Depends on D104020

Latin1/2-byte info in the parse shell function output is added for debugging
BinAST.
To reduce the access to raw ParserAtom, remove the info.

Depends on D104022

Depends on D104024

Depends on D104028

Depends on D104029

Also removed ParserAtom variant of IsIdentifierNameOrPrivateName.

Depends on D104031

Depends on D104036

Depends on D104037

Depends on D104038

Depends on D104039

Depends on D104041

Blocks: 1689434
Attachment #9201120 - Attachment description: Bug 1689892 - Part 29 - Remove ParserAtom::toJSAtom. → Bug 1689892 - Part 29: Remove ParserAtom::toJSAtom.

Please add a set of dump methods to the table as well. I'm finding it tough to work on the Parser with tagged-indices. A "parserAtoms()" method on the ParserSharedBase would be great too.

A similar "parserAtoms()" method on BCE and on CompilationStencil using a consistent name would be useful while debugging too.

Attachment #9201092 - Attachment description: Bug 1689892 - Part 1: Hide well-known/static atom accessors. → Bug 1689892 - Part 1: Hide well-known/static atom accessors. r=tcampbell
Attachment #9201093 - Attachment description: Bug 1689892 - Part 2: Merge ParserAtomEntry and ParserName into ParserAtom. → Bug 1689892 - Part 2: Merge ParserAtomEntry and ParserName into ParserAtom. r=tcampbell
Attachment #9201094 - Attachment description: Bug 1689892 - Part 3: Add ParserAtomsTable::isPrivateName. → Bug 1689892 - Part 3: Add ParserAtomsTable::isPrivateName. r=tcampbell
Attachment #9201095 - Attachment description: Bug 1689892 - Part 4: Add ParserAtomsTable::toNumber. → Bug 1689892 - Part 4: Add ParserAtomsTable::toNumber. r=tcampbell
Attachment #9201096 - Attachment description: Bug 1689892 - Part 5: Add ParserAtomsTable::isIndex. → Bug 1689892 - Part 5: Add ParserAtomsTable::isIndex. r=tcampbell
Attachment #9201097 - Attachment description: Bug 1689892 - Part 6: Add ParserAtomsTable::toNewUTF8CharsZ. → Bug 1689892 - Part 6: Add ParserAtomsTable::toNewUTF8CharsZ. r=tcampbell
Attachment #9201098 - Attachment description: Bug 1689892 - Part 7: Add ParserAtomsTable::toPrintableString. → Bug 1689892 - Part 7: Add ParserAtomsTable::toPrintableString. r=tcampbell
Attachment #9201099 - Attachment description: Bug 1689892 - Part 8: Add ParserAtomsTable::toQuotedString. → Bug 1689892 - Part 8: Add ParserAtomsTable::toQuotedString. r=tcampbell
Attachment #9201100 - Attachment description: Bug 1689892 - Part 9: Add ParserAtomsTable::dumpCharsNoQuote. → Bug 1689892 - Part 9: Add ParserAtomsTable::dumpCharsNoQuote. r=tcampbell
Attachment #9201101 - Attachment description: Bug 1689892 - Part 10: Remove Latin1/2-byte info from parse shell function output. → Bug 1689892 - Part 10: Remove Latin1/2-byte info from parse shell function output. r=tcampbell
Attachment #9201102 - Attachment description: Bug 1689892 - Part 11: Put newline after label in parse shell function output. → Bug 1689892 - Part 11: Put newline after label in parse shell function output. r=tcampbell
Attachment #9201103 - Attachment description: Bug 1689892 - Part 12: Add ParserAtomsTable::toJSAtom. → Bug 1689892 - Part 12: Add ParserAtomsTable::toJSAtom. r=tcampbell
Attachment #9201105 - Attachment description: Bug 1689892 - Part 14: Simplify ParserAtomSpanBuilder methods. → Bug 1689892 - Part 13: Simplify ParserAtomSpanBuilder methods. r=tcampbell
Attachment #9201106 - Attachment description: Bug 1689892 - Part 15: Remove BaseCompilationStencil::getParserAtomAt. → Bug 1689892 - Part 14: Remove BaseCompilationStencil::getParserAtomAt. r=tcampbell
Attachment #9201107 - Attachment description: Bug 1689892 - Part 16: Add ParserAtomsTable::length. → Bug 1689892 - Part 15: Add ParserAtomsTable::length. r=tcampbell
Attachment #9201108 - Attachment description: Bug 1689892 - Part 17: Add ParserAtomsTable::appendTo. → Bug 1689892 - Part 16: Add ParserAtomsTable::appendTo. r=tcampbell
Attachment #9201109 - Attachment description: Bug 1689892 - Part 18: Add ParserAtomsTable::isExtendedUnclonedSelfHostedFunctionName. → Bug 1689892 - Part 17: Add ParserAtomsTable::isExtendedUnclonedSelfHostedFunctionName. r=tcampbell
Attachment #9201110 - Attachment description: Bug 1689892 - Part 19: Add ParserAtomsTable::isIdentifier. → Bug 1689892 - Part 18: Add ParserAtomsTable::isIdentifier. r=tcampbell
Attachment #9201111 - Attachment description: Bug 1689892 - Part 20: Use StringBuffer when folding string concat. → Bug 1689892 - Part 19: Use StringBuffer when folding string concat. r=tcampbell
Attachment #9201112 - Attachment description: Bug 1689892 - Part 21: Use StringBuffer when creating accessor name. → Bug 1689892 - Part 20: Use StringBuffer when creating accessor name. r=tcampbell
Attachment #9201113 - Attachment description: Bug 1689892 - Part 22: Remove ParserAtomsTable::concatAtoms. → Bug 1689892 - Part 21: Remove ParserAtomsTable::concatAtoms. r=tcampbell
Attachment #9201114 - Attachment description: Bug 1689892 - Part 23: Hide ParserAtomsTable::getParserAtom. → Bug 1689892 - Part 22: Hide ParserAtomsTable::getParserAtom. r=tcampbell
Attachment #9201115 - Attachment description: Bug 1689892 - Part 24: Remove ParserAtom::allocateRaw. → Bug 1689892 - Part 23: Remove ParserAtom::allocateRaw. r=tcampbell
Attachment #9201116 - Attachment description: Bug 1689892 - Part 25: Remove ParserAtom::equalsJSAtom. → Bug 1689892 - Part 24: Remove ParserAtom::equalsJSAtom. r=tcampbell
Attachment #9201117 - Attachment description: Bug 1689892 - Part 26: Cleanup ParserAtom.h. → Bug 1689892 - Part 25: Cleanup ParserAtom.h. r=tcampbell
Attachment #9201118 - Attachment description: Bug 1689892 - Part 27: Remove JSContext::parserNames. → Bug 1689892 - Part 26: Remove JSContext::parserNames. r=tcampbell
Attachment #9201119 - Attachment description: Bug 1689892 - Part 28: Cleanup ParserAtomsTable::markUsedByStencil. → Bug 1689892 - Part 27: Cleanup ParserAtomsTable::markUsedByStencil. r=tcampbell
Attachment #9201120 - Attachment description: Bug 1689892 - Part 29: Remove ParserAtom::toJSAtom. → Bug 1689892 - Part 28: Remove ParserAtom::toJSAtom. r=tcampbell
Attachment #9201386 - Attachment description: Bug 1689892 - Part 30: Inline ParserAtom::{isIndex,toNumber,isPrivateName} into ParserAtomsTable. r=tcampbell! → Bug 1689892 - Part 29: Inline ParserAtom::{isIndex,toNumber,isPrivateName} into ParserAtomsTable. r=tcampbell!

Depends on D104372

Added parserAtoms() to Parser and BCE, in Part 5.

also added ParserAtomsTable::dump in new Part 30.
unfortunately CompilationStencil cannot have parserAtoms(), so instead added dumpAtom to ParserSharedBase, BytecodeEmitter, and BaseCompilationStencil, for consistent debugging experience.

Also, given stencil is const during instantiation, made dump methods const in Part 31.

Attachment #9201111 - Attachment description: Bug 1689892 - Part 19: Use StringBuffer when folding string concat. r=tcampbell → Bug 1689892 - Part 19: Use StringBuffer when folding string concat. r=tcampbell!
Attachment #9201112 - Attachment description: Bug 1689892 - Part 20: Use StringBuffer when creating accessor name. r=tcampbell → Bug 1689892 - Part 20: Use StringBuffer when creating accessor name. r=tcampbell!
Attachment #9201092 - Attachment description: Bug 1689892 - Part 1: Hide well-known/static atom accessors. r=tcampbell → Bug 1689892 - Part 1: Hide well-known/static atom accessors. r=tcampbell!
Attachment #9201093 - Attachment description: Bug 1689892 - Part 2: Merge ParserAtomEntry and ParserName into ParserAtom. r=tcampbell → Bug 1689892 - Part 2: Merge ParserAtomEntry and ParserName into ParserAtom. r=tcampbell!
Attachment #9201094 - Attachment description: Bug 1689892 - Part 3: Add ParserAtomsTable::isPrivateName. r=tcampbell → Bug 1689892 - Part 3: Add ParserAtomsTable::isPrivateName. r=tcampbell!
Attachment #9201095 - Attachment description: Bug 1689892 - Part 4: Add ParserAtomsTable::toNumber. r=tcampbell → Bug 1689892 - Part 4: Add ParserAtomsTable::toNumber. r=tcampbell!
Attachment #9201096 - Attachment description: Bug 1689892 - Part 5: Add ParserAtomsTable::isIndex. r=tcampbell → Bug 1689892 - Part 5: Add ParserAtomsTable::isIndex. r=tcampbell!
Attachment #9201097 - Attachment description: Bug 1689892 - Part 6: Add ParserAtomsTable::toNewUTF8CharsZ. r=tcampbell → Bug 1689892 - Part 6: Add ParserAtomsTable::toNewUTF8CharsZ. r=tcampbell!
Attachment #9201098 - Attachment description: Bug 1689892 - Part 7: Add ParserAtomsTable::toPrintableString. r=tcampbell → Bug 1689892 - Part 7: Add ParserAtomsTable::toPrintableString. r=tcampbell!
Attachment #9201099 - Attachment description: Bug 1689892 - Part 8: Add ParserAtomsTable::toQuotedString. r=tcampbell → Bug 1689892 - Part 8: Add ParserAtomsTable::toQuotedString. r=tcampbell!
Attachment #9201100 - Attachment description: Bug 1689892 - Part 9: Add ParserAtomsTable::dumpCharsNoQuote. r=tcampbell → Bug 1689892 - Part 9: Add ParserAtomsTable::dumpCharsNoQuote. r=tcampbell!
Attachment #9201101 - Attachment description: Bug 1689892 - Part 10: Remove Latin1/2-byte info from parse shell function output. r=tcampbell → Bug 1689892 - Part 10: Remove Latin1/2-byte info from parse shell function output. r=tcampbell!
Attachment #9201102 - Attachment description: Bug 1689892 - Part 11: Put newline after label in parse shell function output. r=tcampbell → Bug 1689892 - Part 11: Put newline after label in parse shell function output. r=tcampbell!
Attachment #9201103 - Attachment description: Bug 1689892 - Part 12: Add ParserAtomsTable::toJSAtom. r=tcampbell → Bug 1689892 - Part 12: Add ParserAtomsTable::toJSAtom. r=tcampbell!
Attachment #9201105 - Attachment description: Bug 1689892 - Part 13: Simplify ParserAtomSpanBuilder methods. r=tcampbell → Bug 1689892 - Part 13: Simplify ParserAtomSpanBuilder methods. r=tcampbell!
Attachment #9201106 - Attachment description: Bug 1689892 - Part 14: Remove BaseCompilationStencil::getParserAtomAt. r=tcampbell → Bug 1689892 - Part 14: Remove BaseCompilationStencil::getParserAtomAt. r=tcampbell!
Attachment #9201107 - Attachment description: Bug 1689892 - Part 15: Add ParserAtomsTable::length. r=tcampbell → Bug 1689892 - Part 15: Add ParserAtomsTable::length. r=tcampbell!
Attachment #9201108 - Attachment description: Bug 1689892 - Part 16: Add ParserAtomsTable::appendTo. r=tcampbell → Bug 1689892 - Part 16: Add ParserAtomsTable::appendTo. r=tcampbell!
Attachment #9201109 - Attachment description: Bug 1689892 - Part 17: Add ParserAtomsTable::isExtendedUnclonedSelfHostedFunctionName. r=tcampbell → Bug 1689892 - Part 17: Add ParserAtomsTable::isExtendedUnclonedSelfHostedFunctionName. r=tcampbell!
Attachment #9201110 - Attachment description: Bug 1689892 - Part 18: Add ParserAtomsTable::isIdentifier. r=tcampbell → Bug 1689892 - Part 18: Add ParserAtomsTable::isIdentifier. r=tcampbell!
Attachment #9201113 - Attachment description: Bug 1689892 - Part 21: Remove ParserAtomsTable::concatAtoms. r=tcampbell → Bug 1689892 - Part 21: Remove ParserAtomsTable::concatAtoms. r=tcampbell!
Attachment #9201114 - Attachment description: Bug 1689892 - Part 22: Hide ParserAtomsTable::getParserAtom. r=tcampbell → Bug 1689892 - Part 22: Hide ParserAtomsTable::getParserAtom. r=tcampbell!
Attachment #9201115 - Attachment description: Bug 1689892 - Part 23: Remove ParserAtom::allocateRaw. r=tcampbell → Bug 1689892 - Part 23: Remove ParserAtom::allocateRaw. r=tcampbell!
Attachment #9201116 - Attachment description: Bug 1689892 - Part 24: Remove ParserAtom::equalsJSAtom. r=tcampbell → Bug 1689892 - Part 24: Remove ParserAtom::equalsJSAtom. r=tcampbell!
Attachment #9201117 - Attachment description: Bug 1689892 - Part 25: Cleanup ParserAtom.h. r=tcampbell → Bug 1689892 - Part 25: Cleanup ParserAtom.h. r=tcampbell!
Attachment #9201118 - Attachment description: Bug 1689892 - Part 26: Remove JSContext::parserNames. r=tcampbell → Bug 1689892 - Part 26: Remove JSContext::parserNames. r=tcampbell!
Attachment #9201119 - Attachment description: Bug 1689892 - Part 27: Cleanup ParserAtomsTable::markUsedByStencil. r=tcampbell → Bug 1689892 - Part 27: Cleanup ParserAtomsTable::markUsedByStencil. r=tcampbell!
Attachment #9201120 - Attachment description: Bug 1689892 - Part 28: Remove ParserAtom::toJSAtom. r=tcampbell → Bug 1689892 - Part 28: Remove ParserAtom::toJSAtom. r=tcampbell!
Attachment #9201104 - Attachment is obsolete: true
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/85c9a010945c Part 1: Hide well-known/static atom accessors. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/f9e2666bf301 Part 2: Merge ParserAtomEntry and ParserName into ParserAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/d1cbd27747f8 Part 3: Add ParserAtomsTable::isPrivateName. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/639ee602864a Part 4: Add ParserAtomsTable::toNumber. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/c29f32d422eb Part 5: Add ParserAtomsTable::isIndex. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/8e8144338c6d Part 6: Add ParserAtomsTable::toNewUTF8CharsZ. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/ef285bd6c1fc Part 7: Add ParserAtomsTable::toPrintableString. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/34f3ecca3809 Part 8: Add ParserAtomsTable::toQuotedString. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/bba0db1041fb Part 9: Add ParserAtomsTable::dumpCharsNoQuote. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/7bc8b48a1c9d Part 10: Remove Latin1/2-byte info from parse shell function output. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/266e6140dd1e Part 11: Put newline after label in parse shell function output. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/ccf63c1fdec7 Part 12: Add ParserAtomsTable::toJSAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/ec14d7f6213a Part 13: Simplify ParserAtomSpanBuilder methods. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/1c79beeead63 Part 14: Remove BaseCompilationStencil::getParserAtomAt. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/4ab154f38cf0 Part 15: Add ParserAtomsTable::length. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/95a4c4eea098 Part 16: Add ParserAtomsTable::appendTo. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/f1eb1fc30f5b Part 17: Add ParserAtomsTable::isExtendedUnclonedSelfHostedFunctionName. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/ed6cc4612b9b Part 18: Add ParserAtomsTable::isIdentifier. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/013508ca9b54 Part 19: Use StringBuffer when folding string concat. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/9b5d0ca4ed9d Part 20: Use StringBuffer when creating accessor name. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/fbececd93707 Part 21: Remove ParserAtomsTable::concatAtoms. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/c21f885017e1 Part 22: Hide ParserAtomsTable::getParserAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/95001c13ec10 Part 23: Remove ParserAtom::allocateRaw. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/76359ef43eff Part 24: Remove ParserAtom::equalsJSAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/458d73fd5570 Part 25: Cleanup ParserAtom.h. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/4d70abf61922 Part 26: Remove JSContext::parserNames. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/c2b234ffef9a Part 27: Cleanup ParserAtomsTable::markUsedByStencil. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/66dd73e65cfe Part 28: Remove ParserAtom::toJSAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/1f98bd3f866b Part 29: Inline ParserAtom::{isIndex,toNumber,isPrivateName} into ParserAtomsTable. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/0400fd2ce99d Part 30: Add ParserAtomsTable::dump and {ParserSharedBase,BytecodeEmitter,BaseCompilationStencil}::dumpAtom. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/c23b6266f08d Part 31: Make dump methods const. r=tcampbell

https://hg.mozilla.org/mozilla-central/rev/85c9a010945c
https://hg.mozilla.org/mozilla-central/rev/f9e2666bf301
https://hg.mozilla.org/mozilla-central/rev/d1cbd27747f8
https://hg.mozilla.org/mozilla-central/rev/639ee602864a
https://hg.mozilla.org/mozilla-central/rev/c29f32d422eb
https://hg.mozilla.org/mozilla-central/rev/8e8144338c6d
https://hg.mozilla.org/mozilla-central/rev/ef285bd6c1fc
https://hg.mozilla.org/mozilla-central/rev/34f3ecca3809
https://hg.mozilla.org/mozilla-central/rev/bba0db1041fb
https://hg.mozilla.org/mozilla-central/rev/7bc8b48a1c9d
https://hg.mozilla.org/mozilla-central/rev/266e6140dd1e
https://hg.mozilla.org/mozilla-central/rev/ccf63c1fdec7
https://hg.mozilla.org/mozilla-central/rev/ec14d7f6213a
https://hg.mozilla.org/mozilla-central/rev/1c79beeead63
https://hg.mozilla.org/mozilla-central/rev/4ab154f38cf0
https://hg.mozilla.org/mozilla-central/rev/95a4c4eea098
https://hg.mozilla.org/mozilla-central/rev/f1eb1fc30f5b
https://hg.mozilla.org/mozilla-central/rev/ed6cc4612b9b
https://hg.mozilla.org/mozilla-central/rev/013508ca9b54
https://hg.mozilla.org/mozilla-central/rev/9b5d0ca4ed9d
https://hg.mozilla.org/mozilla-central/rev/fbececd93707
https://hg.mozilla.org/mozilla-central/rev/c21f885017e1
https://hg.mozilla.org/mozilla-central/rev/95001c13ec10
https://hg.mozilla.org/mozilla-central/rev/76359ef43eff
https://hg.mozilla.org/mozilla-central/rev/458d73fd5570
https://hg.mozilla.org/mozilla-central/rev/4d70abf61922
https://hg.mozilla.org/mozilla-central/rev/c2b234ffef9a
https://hg.mozilla.org/mozilla-central/rev/66dd73e65cfe
https://hg.mozilla.org/mozilla-central/rev/1f98bd3f866b
https://hg.mozilla.org/mozilla-central/rev/0400fd2ce99d
https://hg.mozilla.org/mozilla-central/rev/c23b6266f08d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: