Move 'View Image' on content context menu to become 'Open Image in New Tab'
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | verified |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-context-menus])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
||
Comment 6•4 years ago
|
||
Verified that this works as expected in latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).
The commit message says that it should now only default to opening in a new tab. Is there still a way to open images in the same tab then? I wasn't able to glean anything from the diff in that regard, and I didn't find a corresponding pref in about.config either.
|
|
Assignee | |
Comment 8•4 years ago
|
||
We could make it so that ctrl/command + click or middle click opens in the same tab. I thought that I had done that, but it doesn't seem that way. Regardless, that should be a new bug.
Thank you; I created a new issue at Bug 1699128. I wasn't sure how to set the milestone to the 88 Branch, but I hope the rest of the information is sufficient for tracking.
|
|
||
Updated•4 years ago
|
|
||
Comment 12•4 years ago
|
||
Major issues with the above change:
- left click and middle click do the same now.
- no option anymore to open link in current tab
My suggestion to approach this is to extend the whereToOpenLink() function, see related issues:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1699128#c76
- https://bugzilla.mozilla.org/show_bug.cgi?id=1706487#c10
IMHO we should eventually be able to have
- left click open in either new foreground tab or (optionally) current tab
- middle click open either in new background tab or (optionally) new foreground tab
Description
•