Closed Bug 1690140 Opened 4 years ago Closed 4 years ago

Focus outline is just too noticeable with the non-native theme

Categories

(Core :: Widget, defect, P2)

Unspecified
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1689615
Fission Milestone M7

People

(Reporter: evilpie, Unassigned)

References

Details

(Whiteboard: fission-nnt)

Attachments

(1 file)

Steps to reproduce:

What you get:
There is huge blue border only on the left side. It looks very weird and distracting.

What I expected:
In the native GTK theme there is only like one pixel of black on the left side. I had literally not seen it before Emilio pointed it out to me. I think in combination with the cursor appearing at the same time it's almost not noticeable.
Chrome seems to have a smallish border around the whole input.

Personal aside: I think the current focus outline should not be shipped. It's simply too much. Chrome on Linux has like maybe 2px. GTK was even less for me.

I don't see focus outline for the TU-ID or Passwort fields whatsoever with widget.disable-native-theme-for-content on Windows. Is there a Linux-specific code path?

Tracking for Fission M7 Beta.

Severity: -- → S3
Fission Milestone: --- → M7
OS: Unspecified → Linux
Priority: -- → P2
Whiteboard: fission-nnt
Attached image Screenshot_TU-ID.png (deleted) —

I can reproduce this bug in a clean profile. Here's a screenshot from macOS. (I wasn't able to reproduce on Windows earlier due to some profile problem I haven't diagnosed yet.)

I just filed bug 1690194 about the dark blue focus ring being much darker than what was spec'd, but that might be a duplicate of this bug now that I've seen it.

So... bug 1689615 makes it just one ring, which should improve this significantly.

I think that's fine. We could make it a 1px ring if needed, and paint it over the border, which would match chrome, but that seems unfortunate to me because it doesn't behave like a regular outline anymore.

Please reopen if you disagree or think it's still too much after the change in bug 1689615.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: