Open Bug 1690428 Opened 4 years ago Updated 1 years ago

It's hard to see which page is the current page in the PDF sidebar

Categories

(Firefox :: PDF Viewer, defect, P1)

x86_64
Linux
defect

Tracking

()

REOPENED
115 Branch
Accessibility Severity s3

People

(Reporter: MatsPalmgren_bugz, Assigned: calixte)

Details

(Keywords: access, Whiteboard: [pdfjs-accessibility])

Attachments

(3 files)

Attached image screenshot (deleted) —

The only indication of the current page is a slightly darker grey outline on a light grey background. I find this hard to see. I'm attaching a screenshot comparing Firefox (left) with Chrome (right). Chrome uses a light blue outline around the current page on a dark grey background which I find much easier to see. It also dims all the other pages (not sure if I like that though).

Maybe we can switch to a blue outline? (blue because it indicates "selected").

(I'm using Nightly on Linux)

Morgan, is this a problem for accessibility?

Flags: needinfo?(mreschenberg)

(In reply to Marco Castelluccio [:marco] from comment #1)

Morgan, is this a problem for accessibility?

Yep! This is an issue for low-vision folks especially.
If it's possible to use the system accent color here (instead of a static firefox-palette color) that'd be great. I think -moz-accent-color should work for that.
In High Contrast Mode on Windows, we should be using the SelectedItem color

Flags: needinfo?(mreschenberg)

It'd be great if you can help set the severity for this one, I would say s3 or s4 because it's a relatively hidden piece of UI, but I'm not sure how bad it is for low-vision folks.

Keywords: access
Whiteboard: [pdfjs-accessibility]

(In reply to Marco Castelluccio [:marco] from comment #3)

It'd be great if you can help set the severity for this one, I would say s3 or s4 because it's a relatively hidden piece of UI, but I'm not sure how bad it is for low-vision folks.

Sorry, forgot to needinfo you for the above!

Type: enhancement → defect
Flags: needinfo?(mreschenberg)

All good :)

Flags: needinfo?(mreschenberg)
Whiteboard: [pdfjs-accessibility] → [pdfjs-accessibility][access-s3]
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: P3 → P1

This should be fixed now, Morgan could you verify?

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mreschenberg)
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Attached image image.png (deleted) —
Flags: needinfo?(mreschenberg)

Hmm, I'm not getting a blue accent colour -- this looks largely the same to me. I'm not sure it's fixed.

This is testing with:

Built from https://hg.mozilla.org/mozilla-central/rev/169e7173a60fb69db064292175b3d66a1dbdae65
Flags: needinfo?(mcastelluccio)
Status: RESOLVED → REOPENED
Flags: needinfo?(mcastelluccio) → needinfo?(cdenizet)
Resolution: FIXED → ---

The link was wrong, the PR hasn't landed yet: https://github.com/mozilla/pdf.js/pull/16132.

No longer depends on: 1831389
Flags: needinfo?(cdenizet)
Accessibility Severity: --- → s3
Whiteboard: [pdfjs-accessibility][access-s3] → [pdfjs-accessibility]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: