swgl Crash in [@ mozilla::layers::DataTextureSourceD3D11::DataTextureSourceD3D11]
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox85 | --- | disabled |
firefox86 | --- | disabled |
firefox87 | --- | fixed |
People
(Reporter: aryx, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Crash report: https://crash-stats.mozilla.org/report/index/5456da61-64e5-40f0-87a6-b46c70210203
Reason: EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames of crashing thread:
0 xul.dll mozilla::layers::DataTextureSourceD3D11::DataTextureSourceD3D11 gfx/layers/d3d11/TextureD3D11.cpp:200
1 xul.dll mozilla::wr::RenderCompositorD3D11SWGL::CreateTile gfx/webrender_bindings/RenderCompositorD3D11SWGL.cpp:484
2 xul.dll webrender_bindings::swgl_bindings::{{impl}}::create_tile gfx/webrender_bindings/src/swgl_bindings.rs:1354
3 xul.dll webrender::renderer::Renderer::update_native_surfaces gfx/wr/webrender/src/renderer/mod.rs:4250
4 xul.dll webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer/mod.rs:2102
5 xul.dll webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer/mod.rs:1877
6 xul.dll webrender_bindings::bindings::wr_renderer_render gfx/webrender_bindings/src/bindings.rs:639
7 xul.dll mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:186
8 xul.dll mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:481
9 xul.dll mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:337
Comment 1•4 years ago
|
||
Can we really assume this call will always succeeded? OOM?
Comment 2•4 years ago
|
||
The crash stack clearly shows we are using SW-WR but I don't see how it made that decision; no special prefs set, WR/WR-Qualified are available
, no fallback mentioned in the critical log. The log suggests a fallback would have happened given the repetitions of DCompositionSurface::BeginDraw failed
which disable (Hardware) WebRender.
Assignee | ||
Comment 3•4 years ago
|
||
I just faced the crash that seemed to be related to device reset. bp-8dbe5561-7fa1-422f-84e7-c35ea0210204
Comment 4•4 years ago
|
||
Makes sense that it could fail, either due to OOM or device reset.
Sotaro, do you want to handle this? I assume we'd detect device reset already and recreate the compositor, but we shouldn't crash before that happens.
Assignee | ||
Comment 5•4 years ago
|
||
Yes, I take the bug.
Comment 6•4 years ago
|
||
I think bug 1691344 may be the same issue as this, where we failed to allocate a texture and then crash trying to access it later.
Assignee | ||
Comment 7•4 years ago
|
||
Comment 8•4 years ago
|
||
trivial test case on Windows (Intel HD5500, 8GB RAM) : open the attachment of bug 1693256. Keep clicking on the "increase JS" button till the tab crashes.
mostly you will have OOM|small signature. But occasionally you can get the signature in this bug.
This is what I got : https://crash-stats.mozilla.org/report/index/4c737cb7-102c-4db7-bca6-fd1390210217
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•