On macOS this should open a submenu with options of where to send to (and the options should then send the tab's title + link)

On Windows this should open the OS share dialog with the title and link.

We should be able to borrow/steal implementation details from https://searchfox.org/mozilla-central/rev/927e525f481a93a8f63d27a78ae6201e42b1b1fb/browser/base/content/browser-pageActions.js#1315 .

Adding "Share" to the context menu seems odd, at least on macOS. I took a look at a few other apps, and no browsers that I could find shows Share in the context menu.

Safari, Edge, Brave, Chromium, all place it in the File menu, as requested in bug 1512851.
Even non-browser apps show this in the File menu - for example, News and TextEdit.

Safari additionally shows Share in the toolbar, as does News.

On Windows, Edge does not show Share in the context menu, but shows it in the app menu.

At least on macOS, there is a fairly well-established norm of placing Share in the File menu, so placing it in the context menu here would serve to be inconsistent and also to expand the size of the context menu, making it harder to use.

How is it odd? It's literally built into the right click menu system-wide on macOS, so the fact that Firefox is the only place it doesn't work out of every app that I use is odd. Adding it to the File menu makes sense too. It can be in both places...

(In reply to dylthom from comment #3)

How is it odd? It's literally built into the right click menu system-wide on macOS, so the fact that Firefox is the only place it doesn't work out of every app that I use is odd. Adding it to the File menu makes sense too. It can be in both places...

This bug says nothing about a selection, which is when the Share option appears in other apps - sharing some selected image or text. The page or document being shared is the oddity here on macOS, not the sharing of a selection. If the behavior is different than specified in comment #1, it may not be odd at all - that is not what I am responding to, however.

(In reply to Asif Youssuff from comment #2)

Even non-browser apps show this in the File menu - for example, News and TextEdit.

TextEdit shows "Share" in the context menu just fine without a selection.

I don't think this is anywhere near as odd as you are claiming - "save page" and "send page to device" and so on are also regularly in the context menu in other browsers and in Firefox, "save page to pocket" is already there in Firefox -- it's a logical place to put this item.

Yes, it's going to add an item - but fear not, we're removing several other ones, so the overall length of the menu is unlikely to change much (depends a bit on the specific, uh, context, in which you invoke the context menu).

Note that we're adding it here in part because the meatball (page action) menu is being removed and otherwise there'd be no UI access point for it.

I have no objection to also adding it to the File menu on macOS, but there is a separate bug for that already, and one does not preclude the other. We're not currently planning to tackle the File menu one as part of Proton, though it's possible that this bug being fixed would make it easier to fix that one, in which case I would happily take a patch if one were contributed.

If you have further concerns around this, let's use matrix for that discussion and keep this bug focused on actually implementing this menu.

Depends on D104558

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

https://hg.mozilla.org/mozilla-central/rev/56c41d4630dd
https://hg.mozilla.org/mozilla-central/rev/4e6656514a06

The option is correctly implemented in Windows 10 and macOS using latest Nightly and works as expected. I'll close this bug as verified fixed even though it has status affected for firefox87 flag, that was Nightly 87.

This is another big issue with this implementation: https://bugzilla.mozilla.org/show_bug.cgi?id=1706675.

If you are using Tree Style Tabs on Proton the Share functionality is completely removed and the TST dev can't fix it since the right API calls don't exist yet.