Closed Bug 1690573 Opened 4 years ago Closed 4 years ago

Temporarily enable "Report site compatibility issue" inside Help section of App menu

Categories

(Firefox :: Toolbars and Customization, task, P1)

task

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: RT, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-hamburger-menu] [proton-address-bar])

Attachments

(1 file)

Goal:
With the meatball menu removal as part of Proton, we want to make sure early that our mitigation plan for "Report site compatibility issue" works for the webcompat team in terms of the volume and quality of reports they get as a result of the change.
Once this lands the webcompat team will validate that they approve this change after a few weeks of collecting data.

Acceptance criteria:

  • Enable "Report site issue" by default in the Help section of the Application menu
  • Make this a "pre release" only change so that only nightly, Beta and dev edition users see it. "Report site compatibility issue" is an option of the meatball menu that currently only appears for pre-release users.
Summary: Enable "Report site compatibility issue" inside URL bar → Enable "Report site compatibility issue" inside Help section of App menu
Type: defect → task
Whiteboard: [proton-address-bar]

(Maybe this is actually a Hamburger Menu bug…)

Blocks: proton-hamburger-menu
No longer blocks: proton-address-bar
Whiteboard: [proton-address-bar] → [proton-hamburger-menu]

Is this only going into the app menu, or does this need another bug to add it to the menubar?

For this first attempt it's just going into the App Menu. If the team decides that that has negatively impacted their data, we can come up with alternative places then.

(In reply to Blake Winton (:bwinton) (:☕️) from comment #3)

For this first attempt it's just going into the App Menu. If the team decides that that has negatively impacted their data, we can come up with alternative places then.

I think it is unexpected that the app menu has functions not available in the menu bar - the menu bar has traditionally been a superset of options available in Firefox (and the app menus as a subset) - I think it will be very confusing for the type of experienced user who is likely to use this option, to not have it be available in the "superset" menu and instead "hidden" inside of the ostensibly more pared down app menu.

Be that as it may, this is the option we're testing first. If changes are needed later on, we will open new bugs for them, but they are explicitly out of scope at this time.

Going to put this on [proton-address-bar] as well for tracking. The pageAction should be removed from the webcompat extension when it moves to the Help menu, if that isn't part of this bug (it's just to add a menu entry?) then we'll need a new bug for the address bar.

Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu] [proton-address-bar]

Thanks, Meridel!

The string for the menuitem should be "Report Site Issue…" for both the menubar and appmenu variants, and the item should be placed below the "Task Manager" menuitem and above the "Report Deceptive Site" menuitem.

Thanks Mike for the context.
Just a reminder for the context, that this is an attempt at understanding which impact it will have on the volume of webcompat bugs reporting. And given the results of this experiment, we might want to decide to put "Report Site Issue" elsewhere. I'm saying this because Comment #8 seems to involve quite a lot of work and I would like to avoid people being worn out by something which might be changed in the future. Or maybe I'm reading too much into the comment. :)

Okay, I got up to speed with karlcow and denschub on Matrix about what this is about. Basically, we want to test moving access to the Help menu to see if that's right place, but we want to do it in as cheap a way as possible because we're not 100% certain that the Help menu is the right place.

I've obsoleted comment #8. That'll only be the plan if we decide to do this permanently. I'll come up with a new plan.

Summary: Enable "Report site compatibility issue" inside Help section of App menu → Temporarily enable "Report site compatibility issue" inside Help section of App menu

Taking a run at this.

Assignee: nobody → mconley

We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it is the right spot, we'll
probably do something a little more self-contained, and less hacky.

Severity: -- → S3
Priority: -- → P1
Status: NEW → ASSIGNED

Hey DenSchub, now that soft freeze is over, do you think you might have time to take another look at this?

Flags: needinfo?(dschubert)

Yeah! Looks good, r+'ed.

Flags: needinfo?(dschubert)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef36e9cc55b9 Migrate the report-site-issue UI access point to the Help menu. r=denschub,mixedpuppy,fluent-reviewers,webcompat-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1694352
Regressions: 1696490

We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: