Closed Bug 1690752 Opened 4 years ago Closed 3 years ago

Crash in [@ mozilla::wr::RenderThread::UpdateAndRender]

Categories

(Core :: Graphics: WebRender, defect)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- wontfix
firefox89 --- fixed

People

(Reporter: aryx, Assigned: sotaro)

References

(Blocks 3 open bugs)

Details

(Keywords: crash)

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/060f9fc1-de44-4e61-9a70-44f660210204

Reason: EXC_BAD_INSTRUCTION / EXC_I386_STKFLT
Also reported with EXC_BAD_ACCESS / EXC_I386_GPFLT as this signature.

Top 9 frames of crashing thread:

0 XUL mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:535
1 XUL mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:327
2 XUL base::WaitableEvent::TimedWait ipc/chromium/src/base/waitable_event_posix.cc:181
3 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1201
4 XUL MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:548
5 CoreFoundation _CFAutoreleasePoolPop 
6 XUL base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35
7 XUL MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309
8 XUL base::Thread::ThreadMain ipc/chromium/src/base/thread.cc:191

There is a strange similarity with bug 1690749 in that it also happens on macOS/Intel, started around the same timeframe.

Could the CompositorBridgeParent be dead at the time we run UpdateAndRender?

Severity: -- → S2
Blocks: wr-stability

We are crashing in the call to GetAsyncImagePipelineManager within the same time frame and frequency as bug 1690749, but I'm not seeing it directly related otherwise. It's also unclear how this is macOS-only.
It would help to look at a crash dump and see where the address 0x10993cdb8 is coming from.

Some crash reports has the following stack on compositor thread. It might be related.


WebRenderAPI::~WebRenderAPI()
mozilla::layers::WebRenderBridgeParent::ClearResources()
mozilla::layers::WebRenderBridgeParent::HandleShutdown()

Compositor thread did wait on the following.

Flags: needinfo?(dmalyshau)

I wonder if there was a case that CompositorBridgeParent was destroyed without calling CompositorBridgeParent::ActorDestroy() nor WebRenderBridgeParent::Destroy(). It seems not happen when CompositorBridgeParent is alive.

Depends on: 1697090

Sotaro, I haven't gotten to parse your notes and look into it. If you can take it, please do!

Ok, I take this bug. Though it might be related to Bug 1697579.

Assignee: nobody → sotaro.ikeda.g

Thank you!

Flags: needinfo?(dmalyshau)
Depends on: 1700848
No longer blocks: gfx-triage
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.