Some cleanup in native menu code, round 1
Categories
(Core :: Widget: Cocoa, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [proton-context-menus][mac:mr1])
Attachments
(6 files)
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D104311
|
|
Assignee | |
Comment 3•3 years ago
|
||
The only behavior difference (skipping the app menu) is now a boolean parameter.
Depends on D104312
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D104313
|
|
Assignee | |
Comment 5•3 years ago
|
||
ignore-this-changeset
This patch was automatically generated by running
~/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy widget/cocoa/nsMenu*.mm widget/cocoa/nsStandaloneNativeMenu.mm -fix -checks="readability-braces-around-statements" -p /Users/mstange/code/obj-m-opt/clangd/
Depends on D104314
|
|
Assignee | |
Comment 6•3 years ago
|
||
This patch was generated automatically, using the command
~/.mozbuild/clang-tools/clang-tidy/bin/clang-tidy widget/cocoa/nsMenu*.mm widget/cocoa/nsStandaloneNativeMenu.mm -fix -checks="readability-else-after-return,modernize-use-nullptr" -p /Users/mstange/code/obj-m-opt/clangd/
(and running it repeatedly until the entire if/return/else chain in nsMenuBarX.mm was handled)
Depends on D104315
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/0cb9be29e060 DeCOMtaminate nsINativeMenuService and rename it to mozilla::widget::NativeMenuSupport. r=spohl https://hg.mozilla.org/integration/autoland/rev/87c34a78967e Remove unused method nsMenuBarX::GetLocalizedAccelKey. r=spohl https://hg.mozilla.org/integration/autoland/rev/c4ee687e96d5 Share mostly-duplicated function NativeMenuItemWithLocation. r=spohl https://hg.mozilla.org/integration/autoland/rev/a449e225c1d0 Add missing dom:: namespace annotations in nsMenuItemX.mm. r=spohl https://hg.mozilla.org/integration/autoland/rev/6d5803bffccb Add missing braces in cocoa menu code. r=spohl https://hg.mozilla.org/integration/autoland/rev/1ff6cfdadceb Apply 'readability-else-after-return' and 'modernize-use-nullptr' clang-tidy fixes to native menu code. r=spohl
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060
https://hg.mozilla.org/mozilla-central/rev/87c34a78967e
https://hg.mozilla.org/mozilla-central/rev/c4ee687e96d5
https://hg.mozilla.org/mozilla-central/rev/a449e225c1d0
https://hg.mozilla.org/mozilla-central/rev/6d5803bffccb
https://hg.mozilla.org/mozilla-central/rev/1ff6cfdadceb
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
All references to "@mozilla.org/widget/nativemenuservice;1" were removed in https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060 except for one, in browser/base/content/browser-menubar.inc. This is probably an oversight?
|
||
Comment 10•3 years ago
|
||
(In reply to Olivier Tilloy from comment #9)
All references to "@mozilla.org/widget/nativemenuservice;1" were removed in https://hg.mozilla.org/mozilla-central/rev/0cb9be29e060 except for one, in browser/base/content/browser-menubar.inc. This is probably an oversight?
Thanks for noticing. Looks like https://searchfox.org/mozilla-central/rev/3f97afc8db535f9b0232222cb48cc4cbf8334c76/widget/nsWidgetsCID.h#69-76 is also dead now. I filed bug 1695873.
|
||
Updated•3 years ago
|
Description
•