Closed Bug 1691551 Opened 4 years ago Closed 4 years ago

Add policies for home button

Categories

(Firefox :: Enterprise Policies, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- verified
firefox88 --- verified

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

(Whiteboard: [proton-toolbar])

Attachments

(3 files)

With the upcoming changes to the home button, we need to ensure it is still there for enterprise.

We're going to do this in two phases.

  1. Use the existing of the current homepage policy to keep the home button during migration. To accomplish this, I'll add code to the policy engine that checks for the right Homepage policy settings and if so, allows for a thing called "showHomeButton". Then if any code wants to know if they should show the the home button, they can just call:

if (Services.policies.isAllowed("showHomeButton"))

  1. We're going to add an explicit policy to show the home button similar to what edge and Chrome already have.
Whiteboard: [proton-toolbar]
Attached patch Simple diff for first phase (deleted) — Splinter Review

Unfortunately because policy is focused on disallowing features, I had to do this a little backwards.

In the code, we should

Remove button if Services.policies.isAllowed("removeHomeButtonByDefault")

Assignee: nobody → mozilla
Status: NEW → ASSIGNED

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/f4f4db6515d2 Add enterprise policy for showing the home button. r=emalysz,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Flags: qe-verify+
Attached patch Patch for ESR (deleted) — Splinter Review

Comment on attachment 9212849 [details] [diff] [review]
Patch for ESR

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only change for parity with Firefox 88
  • User impact if declined: None
  • Fix Landed on Version: 88
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only
  • String or UUID changes made by this patch: Adds new policy in FTL
Attachment #9212849 - Flags: approval-mozilla-esr78?
QA Whiteboard: [qa-triaged]

Comment on attachment 9212849 [details] [diff] [review]
Patch for ESR

Policy Engine change needed for Release parity. Approved for 78.10esr.

Attachment #9212849 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+

This is verified fixed using Firefox 88.0b7 (BuildId:20210404185932) and Firefox 78.10.0esr (provided in comment 9).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1706337
No longer regressions: 1706337
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: