Add policies for home button
Categories
(Firefox :: Enterprise Policies, enhancement, P1)
Tracking
()
People
(Reporter: mkaply, Assigned: mkaply)
References
Details
(Whiteboard: [proton-toolbar])
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
RyanVM
:
approval-mozilla-esr78+
|
Details | Diff | Splinter Review |
With the upcoming changes to the home button, we need to ensure it is still there for enterprise.
We're going to do this in two phases.
- Use the existing of the current homepage policy to keep the home button during migration. To accomplish this, I'll add code to the policy engine that checks for the right Homepage policy settings and if so, allows for a thing called "showHomeButton". Then if any code wants to know if they should show the the home button, they can just call:
if (Services.policies.isAllowed("showHomeButton"))
- We're going to add an explicit policy to show the home button similar to what edge and Chrome already have.
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Unfortunately because policy is focused on disallowing features, I had to do this a little backwards.
In the code, we should
Remove button if Services.policies.isAllowed("removeHomeButtonByDefault")
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.
Assignee | ||
Comment 3•4 years ago
|
||
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9212849 [details] [diff] [review]
Patch for ESR
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only change for parity with Firefox 88
- User impact if declined: None
- Fix Landed on Version: 88
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only
- String or UUID changes made by this patch: Adds new policy in FTL
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9212849 [details] [diff] [review]
Patch for ESR
Policy Engine change needed for Release parity. Approved for 78.10esr.
Comment 9•4 years ago
|
||
bugherder uplift |
Comment 10•4 years ago
|
||
This is verified fixed using Firefox 88.0b7 (BuildId:20210404185932) and Firefox 78.10.0esr (provided in comment 9).
Description
•