modify gfx/layers/apz/test/mochitest/helper_scrollframe_activation_on_load.html and test_layerization.html so they better test the activate all scroll frames code better
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(4 files)
In bug 1690433 we created code to activate all scroll frames, but deferred modifying these tests to more fully test this new code.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D104656
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•4 years ago
|
||
The waitForScroll argument to promiseMoveMouseAndScrollWheelOver determines if we wait for a scroll event (if waitForScroll is true) or a wheel event (if waitForScroll is false). That might not be clear just from looking at it (where one might assume waitForScroll = false means no waiting at all).
In all cases but one in this test we wait for the scroll event.
When activateAllScrollFrames = false I guess this is enough to guarantee that any new metrics have been sent in a transaction. But it is not with activateAllScrollFrames = true for two reasons.
The first is that apz can handle the wheel event for any scroll frame immediately, it will send a repaint request to content which will scroll and send a scroll event. Content can then handle that scroll event without even sending it's current metrics in a transaction. So we need to wait for paints to be flushed.
But even that is not enough because we can wait for a paint but in several cases we need a minimal display port to be cleared to be full display port and that happens in PrepareForSetTargetAPZCNotification, which only happens after content gets the wheel event, which can happen after apz gets the wheel event, and after content gets the scroll event, and after content gets the scroll event and paints.
So we need to wait for the wheel event to rearch content and then wait for paints.
Depends on D104656
|
|
Assignee | |
Comment 6•4 years ago
|
||
The comment in the test should explain.
Depends on D105407
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/69d59541611a
https://hg.mozilla.org/mozilla-central/rev/bd7df680fbe4
https://hg.mozilla.org/mozilla-central/rev/bdf3cad16bb4
https://hg.mozilla.org/mozilla-central/rev/b5ded5d1b5fa
https://hg.mozilla.org/mozilla-central/rev/6236320fabcc
Description
•