Closed Bug 1692039 Opened 4 years ago Closed 4 years ago

remove unused strings about successful login data import and its summary

Categories

(Firefox :: about:logins, task, P3)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: aryx, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug)

https://hg.mozilla.org/integration/autoland/rev/7ac7236854d4#l8.12 added two strings supposed to be used in the user interface:

about-logins-alert-import-title = Import Complete
about-logins-alert-import-message = View detailed import summary

Both seem to be unused - the import summary gets shown by default.

The strings should be removed.

Hey Andrei, can you confirm that these two strings are redundant?

Severity: -- → N/A
Flags: needinfo?(petcuandrei)
Priority: -- → P3

They might have landed by mistake but they are not redundant. They are needed for this mockup https://mozilla.invisionapp.com/share/R3XX2AF2XN5#/screens/423736091_Import_From_CSV

And will be used in this patch https://phabricator.services.mozilla.com/D100639
The casing is wrong on the second one but it is needed.

Flags: needinfo?(petcuandrei)

I forget if we need to assign new strings if you need to change the casing, but that'll get picked up in the patch review for bug 1649940. Marking this as invalid for the mean time.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.