Update bookmark dialogs for proton
Categories
(Firefox :: Bookmarks & History, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | verified |
People
(Reporter: Gijs, Assigned: mtigley)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-modals])
Attachments
(5 files)
keyword.JPG
These dialogs should:
- open as an in-window modal dialog
- show a star icon on the top left when creating a new item (folder / bookmark), see bug 1693008, and the bookmark's icon if editing an existing bookmark with a favicon;
- show a "Save" button as the accept button
- folder dialogs should show titles of "Add bookmarks folder" and "Edit bookmarks folder" (depending on whether the item is new)
- drop the
:after field labels - re-label "Location" as "URL"
- show a smaller, grey-ish text under the tags field with "Use tags to organize and search for bookmarks from the address bar", and similarly "Use keywords to open bookmarks directly from the address bar" under the keywords field.
|
Reporter | |
Comment 1•4 years ago
|
||
There's still some open questions here around Save vs. Add for buttons. I'll try and get those resolved.
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 2•4 years ago
|
||
One day, I will manage to keep a needinfo I want to keep. Or perhaps we can teach bugzilla not to clear them automatically or something...
|
||
Updated•4 years ago
|
|
|
Reporter | |
Comment 3•4 years ago
|
||
OK, we're sticking with "Save" for buttons.
Also, the add/edit bookmark dialog should have the title "Add bookmark" and "Edit bookmark", respectively (no need to quote/copy the bookmark name/title).
Text and design specs are both in figma now.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D108870
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D108871
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D108872
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
||
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e4e16239c273
https://hg.mozilla.org/mozilla-central/rev/49fdb99ba738
https://hg.mozilla.org/mozilla-central/rev/e926ee8c269c
https://hg.mozilla.org/mozilla-central/rev/8040add982c0
|
||
Updated•4 years ago
|
|
||
Comment 12•4 years ago
|
||
Gijs,
It's reading: Use a single keyword to open bookmkarks directly from the address bar
As opposed to: "Use keywords to open bookmarks directly from the address bar" under the keywords field.
Is this alright?
Best regards,
Clara
|
|
Assignee | |
Comment 13•4 years ago
|
||
Hi Clara, yes we made this change in Bug 1705535 to account for the issue where the "Keyword" field only accepts one keyword input.
|
|
||
Comment 15•4 years ago
|
||
Great, in that case I'll update the flags accordingly.
This has been verified in latest both beta and nightly builds. (Nightly 90.0a1 (2021-05-05) (64-bit) and Beta 89.0b8 (64-bit)) for Mac0s 11.4, Ubuntu 20.04, and Windows 10 pro.
Best regards,
Clara
|
|
||
Updated•4 years ago
|
Description
•