Add gfxCriticalNote to RenderTextureHostSWGL::LockSWGLCompositeSurface()
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
It helps to understand Bug 1693208 .
Assignee | ||
Comment 1•4 years ago
|
||
Comment 3•4 years ago
|
||
Backed out for causing cpp bustage on RenderTextureHostSWGL.cpp
backout: https://hg.mozilla.org/integration/autoland/rev/0b213a6414cd679a927ecd3b4a5dd1b6160f684c
failure log: https://treeherder.mozilla.org/logviewer?job_id=330203553&repo=autoland&lineNumber=7846
[task 2021-02-17T07:43:58.458Z] 41:30.50 /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o /dev/null -c -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -ftrivial-auto-var-init=pattern -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API [..] /builds/worker/checkouts/gecko/gfx/webrender_bindings/RendererOGL.cpp -fsyntax-only
[task 2021-02-17T07:43:58.710Z] /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderTextureHostSWGL.cpp:173:7: error: use of undeclared identifier 'gfxCriticalNote'; did you mean 'gfx_critical_note'?
[task 2021-02-17T07:43:58.710Z] gfxCriticalNote << "Unhandled external image format: " << GetFormat();
[task 2021-02-17T07:43:58.710Z] ^~~~~~~~~~~~~~~
[task 2021-02-17T07:43:58.710Z] gfx_critical_note
[task 2021-02-17T07:43:58.711Z] /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/dist/include/mozilla/webrender/webrender_ffi_generated.h:3379:13: note: 'gfx_critical_note' declared here
[task 2021-02-17T07:43:58.711Z] extern void gfx_critical_note(const char *aMsg);
[task 2021-02-17T07:43:58.711Z] ^
[task 2021-02-17T07:43:58.711Z] /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderTextureHostSWGL.cpp:173:23: error: invalid operands to binary expression ('void (const char *)' and 'const char [34]')
[task 2021-02-17T07:43:58.711Z] gfxCriticalNote << "Unhandled external image format: " << GetFormat();
[task 2021-02-17T07:43:58.711Z] ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-02-17T07:43:58.862Z] 2 errors generated.
Assignee | ||
Comment 4•4 years ago
|
||
Updated fix addressed the build failure.
https://treeherder.mozilla.org/jobs?repo=try&revision=cc18564dc01b8a8a2ca4e524386810b9f7ceed58
Comment 6•4 years ago
|
||
bugherder |
Description
•