Add proton styles for in-content buttons
Categories
(Toolkit :: Themes, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [proton-foundations])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See specs in the "Basic-Components" figma.
Padding should be 6/7/8px vertically for small/medium/large buttons, with horizontal padding double that.
4px border radius everywhere.
Colours are settled for light theme, not for dark theme.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
I presume making these styles shared with toolbarbutton's in the browser chrome is out of scope for this bug?
|
|
Assignee | |
Comment 3•4 years ago
|
||
(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #2)
I presume making these styles shared with
toolbarbutton's in the browser chrome is out of scope for this bug?
I wasn't planning on trying to address that in this bug, no - sorry. I'll try to update for ntim's suggestions ASAP and then you could try building off of this patch - does that work for you?
|
|
||
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 years ago
|
||
The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regression caused by this fix.
For more information, please visit auto_nag documentation.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Description
•