Closed Bug 1693403 Opened 4 years ago Closed 4 years ago

Support schema versioning for Manifest v3 differences

Categories

(WebExtensions :: General, enhancement, P2)

enhancement

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [mv3-m1])

Attachments

(1 file, 1 obsolete file)

Determine and implement best way to handle manifest V2 and V3 in schema. Can we avoid duplicating schema files?

Some functions are deprecated.
Some features of some functions are changed.
Some namespaces are changed.
Some decorators (e.g. deprecated) may need differences

The schema parser would need to consider manifest_version in advance.

The idea here is taken from json files in chromium. It's not an attempt to be compatible at a schema level, it just looked like a reasonable approach to dealing with changes.

https://source.chromium.org/chromium/chromium/src/+/master:extensions/common/api/_permission_features.json

min/max_manifest_version keys are available in any schema object, and some schema objects can support an array of objects where differences may be larger.

This illustrates the basics, test in the patch has a bit more to it.

[
      {
        namespace: "MV2",
        max_manifest_version: 2,

        properties: {
          PROP1: { value: 20 },
        },
      },
      {
        namespace: "MV3",
        min_manifest_version: 3,
        properties: {
          PROP1: { value: 20 },
        },
      },
      {
        namespace: "mixed",

        properties: {
          PROP1: [
            { max_manifest_version: 2, value: 20 },
            { min_manifest_version: 3, value: 30 },
          ],
          PROP2: { value: 20 },
        },
]
Summary: schema versioning → Support schema versioning for Manfiest v3 differences
Summary: Support schema versioning for Manfiest v3 differences → Support schema versioning for Manifest v3 differences
Assignee: nobody → mixedpuppy
Priority: -- → P2
Blocks: 1696043

Comment on attachment 9204332 [details]
Bug 1693403 convert schema format for MV3 content_security_policy

Revision D105846 was moved to bug 1696043. Setting attachment 9204332 [details] to obsolete.

Attachment #9204332 - Attachment is obsolete: true

Adding to the "See also" field the pull request for the related changes we'll need to apply on the addons-linter side:

Blocks: 1708509
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a56202a0d743 support manifest versioning in schema r=rpl
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: mv3:m1
Whiteboard: mv3:m1 → [mv3-m1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: