Closed Bug 1693495 Opened 4 years ago Closed 2 years ago

Introduce a command for network actions and start with blocking requests

Categories

(DevTools :: Netmonitor, task, P3)

Product:
DevTools
Component:
Netmonitor
Type:
task

Tracking

(firefox110 fixed)

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(7 files)

Bug 1693495 - [devtools] Introduce Network commands for blocking requests
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Move getBlockRequest to Network command.
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Use commands via commands instead of toolbox in netmonitor connector.
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Remove getTabTarget in favor of Connector.currentTarget.
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Expose "commands" as thunk argument to netmonitor codebase.
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Implement a beginning of "Network" commands, starting with sendHTTPRequest.
(deleted), text/x-phabricator-request
Details
Bug 1693495 - [devtools] Move setBlockedUrls, getBlockedUrls, blockRequest, unblockRequest to NetworkCommand.
(deleted), text/x-phabricator-request
Details

Bug 1691681 will introduce the commands API.
This bug is about introducing the first usage of this API in the netmonitor, via blockRequest calls.

Depends on: 1691681
No longer depends on: 1693494
Severity: -- → S3
Priority: -- → P3
Type: enhancement → task

This help reduce the usages of toolbox, which is very limited in the connector
and help see that it could become mostly a command itself.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

This will help use commands directly and restrict Connector to non-RDP work.
There is a few minor methods related to toolbox integration.

Use new "commands" thunk argument.
We were passing connector as argument whereas we could have fetched it from thunk arguments.

This will help slowly convert Connector/NetMonitorAPI to a command.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e539cdcb4fe [devtools] Use commands via commands instead of toolbox in netmonitor connector. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/9f0c815966fd [devtools] Remove getTabTarget in favor of Connector.currentTarget. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/c52eacebd31b [devtools] Expose "commands" as thunk argument to netmonitor codebase. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/d17dd5ac7ce5 [devtools] Implement a beginning of "Network" commands, starting with sendHTTPRequest. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/10558e1ac891 [devtools] Move setBlockedUrls, getBlockedUrls, blockRequest, unblockRequest to NetworkCommand. r=devtools-reviewers,nchevobbe
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: