Closed Bug 1693574 Opened 4 years ago Closed 3 years ago

[meta] Only use the testActor for retrieving highlighter data

Categories

(DevTools :: Inspector, task)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jdescottes, Unassigned)

References

Details

(Keywords: meta)

The test actor https://searchfox.org/mozilla-central/source/devtools/client/shared/test/test-actor.js is used to interact with the content page in DevTools mochitests.

However this is a target scoped actor, which means it gets destroyed when a target switch occurs.

It can usually be replaced with calls to SpecialPowers.spawn.

Depends on: 1705753
Depends on: 1705769
Depends on: 1708106
Depends on: 1708252
Depends on: 1713557
Depends on: 1713560
Depends on: 1713568
Depends on: 1714009
Depends on: 1714010
Depends on: 1714291
Depends on: 1714298

we probably won't be able to completely get rid of this actor as we still need to be able to test highlighter, but once we trimmed the actor from all the non-highlighter related methods, we could probably rename it to HighlighterTestActor (or CanvasFrameAnonymousContentHelperActor as it's also used for things that might not be seen as highlighters, e.g. eyedropper, paused debugger overlay, …)

Depends on: 1714518
Depends on: 1714560
Depends on: 1714920
Depends on: 1714994
Depends on: 1715448
Depends on: 1715802
Depends on: 1715938
Depends on: 1715949
Depends on: 1715951
Depends on: 1716265
Depends on: 1716266
Depends on: 1716268
Summary: [meta] Stop using the testActor in devtools tests → [meta] Only use the testActor for retrieving highlighter data
Depends on: 1716703

All the blockers have been fixed, we can close this meta now

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.