Closed Bug 1694481 Opened 4 years ago Closed 4 years ago

Remove Fennec code from GeckoAppShell

Categories

(GeckoView :: General, task, P3)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: agi, Assigned: agi)

References

(Blocks 1 open bug)

Details

Attachments

(13 files, 1 obsolete file)

Bug 1694481 - Remove unused telemetry methods.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Don't use androidBridge to determine if we're on Android.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove fennec code in webcompat
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove Fennec code in nsIAndroidBridge.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused android:// protocol handler
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused DirectBufferAllocator.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused NativeZip.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused methods in GeckoLoader.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused code from exthandler/android.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused methods in GeckoAppShell.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused android lock screen orientation support.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Simplify Android Listeners in GeckoAppShell.
(deleted), text/x-phabricator-request
Details
Bug 1694481 - Remove unused code in GeckoAppShell.
(deleted), text/x-phabricator-request
Details

While looking at other bugs I noticed that we have a lot of Fennec code in GeckoAppShell and dependent files. So I went ahead and cleaned that up.

Blocks: remove-fennec
Assignee: nobody → agi
Status: NEW → ASSIGNED

androidBridge is an implementation detail that we want to eventually remove.

GeckoAppShell has code to handle custom listeners, but we don't use them anymore.

Attached file Bug 1694481 - Remove GeckoAppShell.KillAnyZombies. (obsolete) (deleted) —

Before this patch, when the profile is locked on Android, we would call "ps",
parse the human-readable output and kill any other Gecko process that we could
find.

But this is completely unnecessary, as we know exactly that the PID of the
process holding the lock is.

In this patch we just kill the process holding the lock since this is
equivalent to the previous behavior.

Severity: -- → S3
Priority: -- → P3

Comment on attachment 9204935 [details]
Bug 1694481 - Remove GeckoAppShell.KillAnyZombies.

Revision D106186 was moved to bug 1697503. Setting attachment 9204935 [details] to obsolete.

Attachment #9204935 - Attachment is obsolete: true
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d17eca939da Remove unused telemetry methods. r=aklotz https://hg.mozilla.org/integration/autoland/rev/2e6cb8ba9f35 Don't use androidBridge to determine if we're on Android. r=whimboo,hiro https://hg.mozilla.org/integration/autoland/rev/a2ef37064afa Remove fennec code in webcompat r=webcompat-reviewers,denschub https://hg.mozilla.org/integration/autoland/rev/1dd274370828 Remove Fennec code in nsIAndroidBridge. r=aklotz https://hg.mozilla.org/integration/autoland/rev/b87758d33be3 Remove unused android:// protocol handler r=aklotz https://hg.mozilla.org/integration/autoland/rev/f56190277eaf Remove unused DirectBufferAllocator. r=aklotz https://hg.mozilla.org/integration/autoland/rev/4ef4358255f9 Remove unused NativeZip. r=aklotz https://hg.mozilla.org/integration/autoland/rev/56983507ac02 Remove unused methods in GeckoLoader. r=aklotz https://hg.mozilla.org/integration/autoland/rev/7c8a32a8c126 Remove unused code from exthandler/android. r=droeh,esawin https://hg.mozilla.org/integration/autoland/rev/e8790b8f8cdb Remove unused methods in GeckoAppShell. r=aklotz https://hg.mozilla.org/integration/autoland/rev/934ce7e0aa44 Remove unused android lock screen orientation support. r=aklotz https://hg.mozilla.org/integration/autoland/rev/960307705ecd Simplify Android Listeners in GeckoAppShell. r=aklotz https://hg.mozilla.org/integration/autoland/rev/710cb79b91f7 Remove unused code in GeckoAppShell. r=aklotz
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: