Closed
Bug 1694525
Opened 4 years ago
Closed 4 years ago
unhandled exception when browsertime fails to start takes 1 hour to exit
Categories
(Testing :: Raptor, defect, P2)
Tracking
(firefox88 fixed)
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: aerickson, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
When browsertime fails to start, mozprocess sits waiting for output for an hour.
See Bug 1694275 for my original report. Task log with stack trace attached to that bug: https://bugzilla.mozilla.org/attachment.cgi?id=9204695
Per :gbrown in the above bug, this is due to an unhandled exception in Raptor's line handler.
The Raptor line handler:
- should use kill() to signal to mozprocess that it's done (when it fails to start, etc)
- ideally, shouldn't throw any exceptions in the line handler (catch all and log)
Updated•4 years ago
|
Severity: -- → S2
Priority: -- → P2
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → whole.grains
Assignee | ||
Comment 1•4 years ago
|
||
Currently, raising an exception in a mozprocess callback is not guaranteed to
end the managed process; after bug 1694275, the exception will be reported but
otherwise suppressed.
Instead of raising an exception, report the error and end the test process.
Pushed by whole.grains@protonmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ef59030e7c9
End browsertime test process when error encountered; r=perftest-reviewers,sparky
Assignee | ||
Comment 3•4 years ago
|
||
This appears to be working as expected:
https://treeherder.mozilla.org/logviewer?job_id=331378948&repo=autoland&lineNumber=920
Comment 4•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•